[OS-BUILD PATCH] redhat: avoid picking up stray editor backups when processing configs

[Clark Williams (via Email Bridge)]

From: Clark Williams <williams(a)redhat.com&gt;

redhat: avoid picking up stray editor backups when processing configs

Emacs and vim both use a trailing '~' to designate a backup file. This
can cause puzzling behavior in the config generation logic because the
build_configs.sh script will pick up both CONFIG_FOO and CONFIG_FOO~,
which presumably have different values. Just avoid this by filtering
out files with ~ extension when picking up CONFIGS from a directory.

Signed-off-by: Clark Williams <williams(a)redhat.com&gt;

diff --git a/redhat/configs/build_configs.sh b/redhat/configs/build_configs.sh
index blahblah..blahblah 100755
--- a/redhat/configs/build_configs.sh
+++ b/redhat/configs/build_configs.sh
@@ -49,7 +49,8 @@ function combine_config_layer()
 		return
 	fi
 
-	cat "$dir"/CONFIG_* > "$file"
+	# avoid picking up editor backup files
+	cat $(ls -1 "$dir"/CONFIG_* | grep -v "~$") > "$file"
 }
 
 function merge_configs()

--
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2149

[Prarit Bhargava (via Email Bridge)]

From: Prarit Bhargava on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2149#note_1172...

Oh I missed the merge :(  I was going to suggest trying to add ~* to
.gitignore to see if that fixes the problem.

[Don Zickus (via Email Bridge)]

From: Don Zickus on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2149#note_1172...

@prarit - I don't think it will because we are running a 'cat' command not a
'git' command.

[Clark Williams (via Email Bridge)]

From: Clark Williams on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2149#note_1172...

Yeah, this is run from a shell script that is examining the contents of the
filesystem; no git being used here