[389-devel] Please review: [Bug 585905] ACL with targattrfilters error crashes the server

[Noriko Hosoi]

585905 - ACL with targattrfilters error crashes the server

https://bugzilla.redhat.com/attachment.cgi?id=409325&action=diff

https://bugzilla.redhat.com/attachment.cgi?id=409325&action=edit

Bug Description:
targattrfilters takes this format of value:
  (targattrfilters="add=attr1:F1 && attr2:F2... &&
   attrn:Fn,del=attr1:F1 && attr2:F2 ... && attrn:Fn")
The ACL plugin code had blindly expected the value contains
the operator "add" or "del" and '=' to concatenate the
attribute and filter pair.  The plugin should have checked
the possibility that the value does not follow the format.

Fix Description:
If '=' is not included in the targattrfilters value, the
ACL parser returns ACL_SYNTAX_ERR.

Thanks,
--noriko

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 6646 bytes
Desc: S/MIME Cryptographic Signature
Url : http://lists.fedoraproject.org/pipermail/389-devel/attachments/20100426/82926c24/attachment.bin