[PATCH 2/2] Coverity defects
Noriko Hosoi
nhosoi at redhat.com
Thu Aug 30 22:38:57 UTC 2012
13089: Dereference after null check
ldbm_back_delete (back-ldbm/ldbm_delete.c)
Goto error_return if either of addr or sdnp is NULL.
---
ldap/servers/slapd/back-ldbm/ldbm_delete.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/ldap/servers/slapd/back-ldbm/ldbm_delete.c b/ldap/servers/slapd/back-ldbm/ldbm_delete.c
index fa8221c..580fe4c 100644
--- a/ldap/servers/slapd/back-ldbm/ldbm_delete.c
+++ b/ldap/servers/slapd/back-ldbm/ldbm_delete.c
@@ -124,9 +124,11 @@ ldbm_back_delete( Slapi_PBlock *pb )
slapi_log_error (SLAPI_LOG_TRACE, "ldbm_back_delete", "enter conn=%" NSPRIu64 " op=%d\n", pb->pb_conn->c_connid, operation->o_opid);
}
- if ((NULL == addr) && (NULL == sdnp))
+ if ((NULL == addr) || (NULL == sdnp))
{
/* retval is -1 */
+ slapi_log_error(SLAPI_LOG_FATAL, "ldbm_back_delete",
+ "Either of DELETE_TARGET_SDN or TARGET_ADDRESS is NULL.\n");
goto error_return;
}
dn = slapi_sdn_get_dn(sdnp);
--
1.7.11.4
--------------030203020205000201010102--
More information about the 389-devel
mailing list