[389-devel] Please review (take 2): [389 Project] #537: Improvement of range search

Noriko Hosoi nhosoi at redhat.com
Fri Jan 11 01:52:57 UTC 2013


https://fedorahosted.org/389/ticket/537

https://fedorahosted.org/389/attachment/ticket/537/0001-Ticket-537-Improvement-of-range-search.2.patch

Thanks to Rich for his reviews and comments.  I've added the read 
transaction abort in case idl_new_fetch / idl_new_range_fetch failed in 
the transaction.

Fix description: The index range search function index_range
_read_ext was written to call idl_fetch_ext to get an idlist
belonging to one key. Then add it to the main idlist as long
as the key satisfiles the range search filter condition.
This patch introduces a new range search function idl_new_
range_fetch to the new idl code, which generates an idlist
in one idl function that eliminates the redundancy such as
generating idlist and cursor per key.

This patch only implements the new idl version.  If idl_new
is not set, the existing code is executed.

*Additionally, idl_new_fetch did not abort the read transaction**
**even if any error occurred in the transaction. Now, it switches**
**between commit and abort based upon the result.*

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.fedoraproject.org/pipermail/389-devel/attachments/20130110/dca74e68/attachment.html>


More information about the 389-devel mailing list