[389-devel] Please review: various lib389 cleanups

[thierry bordaz]

Hi,

The changes look  very good.

I have a question regarding start/stop in Replica class. Why do not you 
use the function self.agreement.schedule(agmdn, interval='start') and 
self.agreement.schedule(agmdn, interval='stop') ?

about the function 'agreement_dn(basedn, other)' why not putting it into 
the Agreement class ?
Note that it uses the functions 'agreements' that is Replica but I would 
expect it to be in Agreement class as well (renamed in 'list' ?).

Regards
thierry

On 11/21/2013 03:21 AM, Rich Megginson wrote:
>
>
>
> --
> 389-devel mailing list
> 389-devel at lists.fedoraproject.org
> https://admin.fedoraproject.org/mailman/listinfo/389-devel

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.fedoraproject.org/pipermail/389-devel/attachments/20131121/607dd9dc/attachment.html>