[389-devel] Please review: [389 Project] #47555: db2bak.pl issue when specifying non-default directory

[Noriko Hosoi]

https://fedorahosted.org/389/attachment/ticket/47555/0001-Ticket-47555-db2bak.pl-issue-when-specifying-non-def.patch

  Bug description: db2bak.pl takes an option "-a backupdir", which is
  supposed to be generated by the server and used as a backup directory.
  But since the created directory inherits the parent's selinux context,
  it may fail to store the backup files in the directory.

  Fix description: As the reporter agaviola suggested, it should be a
  good idea to add one more level to the archive directory.
      $archivedir = "${archivedir}/ID-${yr}_${mn}_${dy}_${h}_${m}_${s}";
  But to keep the backward compatibility, introducing a new option "-A
  backupdir" and when "-A" is given, storing the backup files in the
  nested backup directory.  If the option is "-a backupdir", the backup
  files are stored in the backupdir.

  Also, this patch sets the right ownership and selinux context to the
  generated directory.  Note: if the parent directories of the created
  backupdir do not have the correct selinux context, even if the last
  directory's setting is correct, storing the backup files fails.  It
  is the user's responsibility to set them correctly.