<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#ffffff" text="#000000">
On 04/19/2011 01:50 PM, Noriko Hosoi wrote:
<blockquote cite="mid:4DADF598.8010604@redhat.com" type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
On 04/19/2011 01:44 PM, Nathan Kinder wrote:
<blockquote cite="mid:4DADF42A.1080507@redhat.com" type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
I've attached a revised patch to address some comments given by
Noriko. The only differences here are in the plug-in close()
function. We free the config lock now, and we also check if the
started flag was set before freeing any of the resources.<br>
<br>
On 04/19/2011 08:52 AM, Nathan Kinder wrote:
<blockquote cite="mid:4DADAFBD.7080004@redhat.com" type="cite"><a
moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://directory.fedoraproject.org/wiki/Auto_Membership_Design">http://directory.fedoraproject.org/wiki/Auto_Membership_Design</a>
<br>
<pre wrap=""><fieldset class="mimeAttachmentHeader"></fieldset>
--
389-devel mailing list
<a moz-do-not-send="true" class="moz-txt-link-abbreviated" href="mailto:389-devel@lists.fedoraproject.org">389-devel@lists.fedoraproject.org</a>
<a moz-do-not-send="true" class="moz-txt-link-freetext" href="https://admin.fedoraproject.org/mailman/listinfo/389-devel">https://admin.fedoraproject.org/mailman/listinfo/389-devel</a></pre>
</blockquote>
<br>
<pre wrap=""><fieldset class="mimeAttachmentHeader"></fieldset>
--
389-devel mailing list
<a moz-do-not-send="true" class="moz-txt-link-abbreviated" href="mailto:389-devel@lists.fedoraproject.org">389-devel@lists.fedoraproject.org</a>
<a moz-do-not-send="true" class="moz-txt-link-freetext" href="https://admin.fedoraproject.org/mailman/listinfo/389-devel">https://admin.fedoraproject.org/mailman/listinfo/389-devel</a></pre>
</blockquote>
Reviewed++.<br>
</blockquote>
Thanks for your review! Pushed to master.<br>
<br>
Counting objects: 42, done.<br>
Delta compression using up to 2 threads.<br>
Compressing objects: 100% (23/23), done.<br>
Writing objects: 100% (24/24), 17.83 KiB, done.<br>
Total 24 (delta 15), reused 0 (delta 0)<br>
To ssh://git.fedorahosted.org/git/389/ds.git<br>
fe9b6a6..006083a master -> master<br>
<blockquote cite="mid:4DADF598.8010604@redhat.com" type="cite">
<pre wrap="">
<fieldset class="mimeAttachmentHeader"></fieldset>
--
389-devel mailing list
<a class="moz-txt-link-abbreviated" href="mailto:389-devel@lists.fedoraproject.org">389-devel@lists.fedoraproject.org</a>
<a class="moz-txt-link-freetext" href="https://admin.fedoraproject.org/mailman/listinfo/389-devel">https://admin.fedoraproject.org/mailman/listinfo/389-devel</a></pre>
</blockquote>
<br>
</body>
</html>