<html>
  <head>
    <meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
  </head>
  <body bgcolor="#FFFFFF" text="#000000">
    Yes they should be!  Nice catch.<br>
    <br>
    Committing...<br>
    <br>
     ldap/servers/plugins/replication/cl5_clcache.c     |    1 +<br>
     .../plugins/replication/repl5_replica_config.c     |   29
    +++++++++++++-----<br>
     ldap/servers/plugins/rootdn_access/rootdn_access.c |   32
    ++++++++++++--------<br>
     ldap/servers/slapd/back-ldbm/cache.c               |   24
    +++++++++++----<br>
     ldap/servers/slapd/back-ldbm/dblayer.c             |    5 +--<br>
     ldap/servers/slapd/back-ldbm/ldbm_entryrdn.c       |    6 +--<br>
     6 files changed, 63 insertions(+), 34 deletions(-)<br>
    <br>
     git push origin master<br>
    Counting objects: 29, done.<br>
    Delta compression using up to 4 threads.<br>
    Compressing objects: 100% (15/15), done.<br>
    Writing objects: 100% (15/15), 1.92 KiB, done.<br>
    Total 15 (delta 12), reused 0 (delta 0)<br>
    To ssh://git.fedorahosted.org/git/389/ds.git<br>
       8f21ac8..c446a69  master -&gt; master<br>
    <br>
    <br>
    On 06/13/2012 06:22 PM, Noriko Hosoi wrote:
    <blockquote cite="mid:4FD91290.90704@redhat.com" type="cite">
      <meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
      Hi Mark,<br>
      <br>
      diff --git a/ldap/servers/plugins/rootdn_access/rootdn_access.c
      b/ldap/servers/p<br>
      lugins/rootdn_access/rootdn_access.c<br>
      index 7fb5615..23e33dd 100644<br>
      --- a/ldap/servers/plugins/rootdn_access/rootdn_access.c<br>
      +++ b/ldap/servers/plugins/rootdn_access/rootdn_access.c<br>
      [...]<br>
      <br>
      static int<br>
      rootdn_load_config(Slapi_PBlock *pb)<br>
      {<br>
          Slapi_Entry *e = NULL;<br>
          <font color="#990000"><b>char *openTime, *closeTime;</b></font>
      &lt;== These variables should be initialized?<br>
          char hour[3], min[3];<br>
      <br>
      The other fixes look good to me.<br>
      --noriko<br>
      <br>
      Mark Reynolds wrote:
      <blockquote cite="mid:4FD90A37.4090401@redhat.com" type="cite">Attached...

        <br>
        <br>
        Thanks, <br>
        Mark <br>
        <br>
        <br>
        <fieldset class="mimeAttachmentHeader"></fieldset>
        <br>
        <pre wrap="">--
389-devel mailing list
<a moz-do-not-send="true" class="moz-txt-link-abbreviated" href="mailto:389-devel@lists.fedoraproject.org">389-devel@lists.fedoraproject.org</a>
<a moz-do-not-send="true" class="moz-txt-link-freetext" href="https://admin.fedoraproject.org/mailman/listinfo/389-devel">https://admin.fedoraproject.org/mailman/listinfo/389-devel</a></pre>
      </blockquote>
      <br>
      <br>
      <fieldset class="mimeAttachmentHeader"></fieldset>
      <br>
      <pre wrap="">--
389-devel mailing list
<a class="moz-txt-link-abbreviated" href="mailto:389-devel@lists.fedoraproject.org">389-devel@lists.fedoraproject.org</a>
<a class="moz-txt-link-freetext" href="https://admin.fedoraproject.org/mailman/listinfo/389-devel">https://admin.fedoraproject.org/mailman/listinfo/389-devel</a></pre>
    </blockquote>
    <br>
    <pre class="moz-signature" cols="72">-- 
Mark Reynolds
Senior Software Engineer
Red Hat, Inc
<a class="moz-txt-link-abbreviated" href="mailto:mreynolds@redhat.com">mreynolds@redhat.com</a></pre>
  </body>
</html>