<html>
<head>
<meta http-equiv="content-type" content="text/html; charset=ISO-8859-1">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<font face="Times New Roman, Times, serif">This review takes into
account the following recommendations<br>
</font>
<ul>
<li><font face="Times New Roman, Times, serif">skip verbose option
(use of log.level). <br>
</font></li>
<li><font face="Times New Roman, Times, serif">use glob.glob to
retrieve files matching rather that os.walk</font></li>
<li><font face="Times New Roman, Times, serif">fix a bug in
instanceBackupFS that did not return an already existing
backup<br>
</font></li>
<li><font face="Times New Roman, Times, serif">add two functions
to handle instance backup: clearInstanceBackupFS (to remove
one or all backups of an instance), _infoInstanceBackupFS
(just to keep path/pattern info of backup into a single
routine)</font></li>
<li><font face="Times New Roman, Times, serif">do not hard code '/tmp'
as directory to store the backups. A new optional argument
'backupdir' for createInstance, sets the attribute
'dirsrv.backupdir'. By default it takes '/tmp'. The caller of
createInstance (the test case), may provide 'backupdir' from
an environment variable (like it was done with $PREFIX)</font></li>
</ul>
<p><font face="Times New Roman, Times, serif"><a class="moz-txt-link-freetext" href="https://fedorahosted.org/389/attachment/ticket/47584/0004-Ticket-47584-CI-tests-add-backup-restore-of-an-insta.patch">https://fedorahosted.org/389/attachment/ticket/47584/0004-Ticket-47584-CI-tests-add-backup-restore-of-an-insta.patch</a></font><br>
</p>
<br>
</body>
</html>