<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix"><br>
On 11/15/2013 04:16 PM, Roberto Polli wrote:<br>
</div>
<blockquote cite="mid:2169236.BgyauNMA67@rpolli" type="cite">
<pre wrap="">On Friday 15 November 2013 15:18:26 thierry bordaz wrote:
</pre>
<blockquote type="cite">
<pre wrap=""><a class="moz-txt-link-freetext" href="https://fedorahosted.org/389/attachment/ticket/47586/0001-Ticket-47586-CI-te">https://fedorahosted.org/389/attachment/ticket/47586/0001-Ticket-47586-CI-te</a>
sts-test-case-for-47490.patch
</pre>
</blockquote>
<pre wrap="">
1- I'd replace the following:
-from lib389._constants import DN_DM
+from lib389 import DN_DM
Files starting with _ are "private" and are just facilities for the developer.
We could consider to rename _constants to constants
2- To isolate testing tools from the library I would put
args_standalone & co in a proper bugfix harness file/class that we can add to
lib389, eg:
from lib389.bugfix import args_standalone
Otherwise people/projects using lib389 will be full of our testing code.</pre>
</blockquote>
Hi Roberto,<br>
<br>
<blockquote>Thanks for reviewing it. I agree that _constants make no
sense, I will change that.<br>
<br>
I have a question regarding your 2nd point.<br>
Lib389 offers an interface to create an instance 'createInstance'.
This function takes a dict as argument containing the description
of the instance.<br>
For me implementation of that dict should be done by the lib389
user.<br>
What lib389 can offer, is a dict template with default values. Is
that this template that you recommend to put into lib389.bugfix ?<br>
<br>
Note: currently ticket/constant.py contains a arg_standalone. I
think it is not a good idea, as simply a arg_template should be
provided.<br>
<br>
</blockquote>
regards<br>
thierry<br>
<blockquote cite="mid:2169236.BgyauNMA67@rpolli" type="cite">
<pre wrap="">
Peace,
R.
</pre>
</blockquote>
</body>
</html>