<html>
<head>
<meta http-equiv="content-type" content="text/html; charset=ISO-8859-1">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<br>
<font face="Times New Roman, Times, serif"><font face="Times New
Roman, Times, serif">This review takes into account the
recommendations of last review:<br>
</font></font>
<ul>
<li><font face="Times New Roman, Times, serif">It creates a
checkProperties function<br>
This function take properties from a dict. It checks and set
the properties into the LDAP entry of the replication
agreement.<br>
It can checks the coherency of the properties as well as sets
default values.<br>
This function translates what will be CLI properties into
replication agreement parameters.<br>
</font></li>
</ul>
<font face="Times New Roman, Times, serif"><font face="Times New
Roman, Times, serif"> </font><br>
In addition to recommendations of previous reviews<br>
</font>
<ul>
<li><font face="Times New Roman, Times, serif">Create a Agreement
class in brooker</font></li>
<li><font face="Times New Roman, Times, serif">mv
init/status/schedule/create in that new class</font></li>
<li><font face="Times New Roman, Times, serif">mv
createDefaultReplMgr into the brooker replica class with the
function create_repl_manager()<br>
</font></li>
<li><font face="Times New Roman, Times, serif">Handling of error
condition with exceptions</font></li>
</ul>
<p><font face="Times New Roman, Times, serif">What is not
implemented in that review, that will be implemented with <a
class="moz-txt-link-freetext"
href="https://fedorahosted.org/389/ticket/47600">https://fedorahosted.org/389/ticket/47600</a>:<br>
</font></p>
<ul>
<li><font face="Times New Roman, Times, serif">Cleanup of </font>createAgreement
(use of exception). This function will likely be replace by
agreement.create().</li>
<li>Cleanup of enableReplication (use of exception, move under
replica.create()) </li>
</ul>
<font face="Times New Roman, Times, serif"><a class="moz-txt-link-freetext" href="https://fedorahosted.org/389/attachment/ticket/47590/0004-Ticket-47590-CI-tests-add-split-functions-around-rep.patch">https://fedorahosted.org/389/attachment/ticket/47590/0004-Ticket-47590-CI-tests-add-split-functions-around-rep.patch</a></font>
</body>
</html>