<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">On 11/21/2013 01:58 AM, thierry bordaz
wrote:<br>
</div>
<blockquote cite="mid:528DCB18.1020709@redhat.com" type="cite">
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
<div class="moz-cite-prefix">Hi,<br>
<br>
The changes look very good.<br>
<br>
I have a question regarding start/stop in Replica class. Why do
not you use the function self.agreement.schedule(agmdn,
interval='start') and self.agreement.schedule(agmdn,
interval='stop') ?<br>
</div>
</blockquote>
<br>
I will change it to use schedule().<br>
<br>
<blockquote cite="mid:528DCB18.1020709@redhat.com" type="cite">
<div class="moz-cite-prefix"> <br>
about the function 'agreement_dn(basedn, other)' why not putting
it into the Agreement class ?<br>
Note that it uses the functions 'agreements' that is Replica but
I would expect it to be in Agreement class as well (renamed in
'list' ?).<br>
</div>
</blockquote>
<br>
Yes. I think I will change the names also, to pause() and resume().<br>
<br>
I think the following methods should be moved to the Agreement
class: check_init start_and_wait wait_init start_async keep_in_sync
agreement_dn (rename to "dn") agreements (rename to "list") (also,
is it a problem that we have a method name "list" that is the same
as a python keyword/built-in?)<br>
<br>
<blockquote cite="mid:528DCB18.1020709@redhat.com" type="cite">
<div class="moz-cite-prefix"> <br>
Regards<br>
thierry<br>
<br>
On 11/21/2013 03:21 AM, Rich Megginson wrote:<br>
</div>
<blockquote cite="mid:528D6E3F.3020507@redhat.com" type="cite"> <br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">--
389-devel mailing list
<a moz-do-not-send="true" class="moz-txt-link-abbreviated" href="mailto:389-devel@lists.fedoraproject.org">389-devel@lists.fedoraproject.org</a>
<a moz-do-not-send="true" class="moz-txt-link-freetext" href="https://admin.fedoraproject.org/mailman/listinfo/389-devel">https://admin.fedoraproject.org/mailman/listinfo/389-devel</a></pre>
</blockquote>
<br>
</blockquote>
<br>
</body>
</html>