<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<a class="moz-txt-link-freetext" href="https://fedorahosted.org/389/ticket/47571">https://fedorahosted.org/389/ticket/47571</a><br>
<br>
<a class="moz-txt-link-freetext" href="https://fedorahosted.org/389/attachment/ticket/47571/0001-Ticket-47571-targetattr-ACIs-ignore-subtype.4.patch">https://fedorahosted.org/389/attachment/ticket/47571/0001-Ticket-47571-targetattr-ACIs-ignore-subtype.4.patch</a><br>
<div class="change" id="trac-change-15">
<div class="comment searchable">
<p>
Description: commit <a class="changeset"
href="https://fedorahosted.org/389/changeset/85a78741dfeb636a1cf7cced1576278e65f5bb58/"
title="Ticket #47571 - targetattr ACIs ignore subtype
Description:
Subtypes in ...">85a78741dfeb636a1cf7cced1576278e65f5bb58</a><br>
introduced 2 coverity issues:<br>
12423: Explicit null dereferenced<br>
do_search (slapd/search.c)<br>
If attribute list contains multiple "*"s and "aci"s in
ldapsearch,<br>
the previous code attempted to add "aci" once for "*" and
replacing<br>
"aci" with normalized aci (if any) once and eliminating the
duplicated<br>
"aci"s. The code contained a null dereferenced bug. Even if
duplicated<br>
attributes are included in the attribute list, they are
removed later<br>
in send_specific_attrs. Thus, this patch simplifies the logic
to avoid<br>
the null dereference.<br>
</p>
<p>
12422: Logically dead code<br>
comp_cmp (slapd/attr.c)<br>
Eliminated the dead code (case s1 == NULL AND s2 == NULL).<br>
</p>
</div>
</div>
<br>
</body>
</html>