<html>
  <head>
    <meta content="text/html; charset=utf-8" http-equiv="Content-Type">
  </head>
  <body bgcolor="#FFFFFF" text="#000000">
    <br>
    <br>
    <div class="moz-cite-prefix">On 08/07/2015 08:45 AM, Amita Sharma
      wrote:<br>
    </div>
    <blockquote cite="mid:55C4A87E.6040500@redhat.com" type="cite">
      <meta content="text/html; charset=utf-8" http-equiv="Content-Type">
      <br>
      <br>
      <div class="moz-cite-prefix">On 08/06/2015 06:13 PM, Mark Reynolds
        wrote:<br>
      </div>
      <blockquote cite="mid:55C35662.8040605@redhat.com" type="cite">
        <meta http-equiv="Context-Type" content="text/html; ">
        <br>
        <br>
        <div class="moz-cite-prefix">On 08/06/2015 06:24 AM, Amita
          Sharma wrote:<br>
        </div>
        <blockquote cite="mid:55C335C3.70105@redhat.com" type="cite">Hi
          All, <br>
          <br>
          I have automated few test cases for <a moz-do-not-send="true"
            class="moz-txt-link-freetext"
            href="https://fedorahosted.org/389/attachment/ticket/47910/">https://fedorahosted.org/389/attachment/ticket/47910/</a>
          . <br>
          Here is my patch :: <a moz-do-not-send="true"
            class="moz-txt-link-freetext"
href="https://fedorahosted.org/389/attachment/ticket/47910/0001-Ticket-47910-allow-logconv.pl-S-E-switches-to-work-e.2.patch">https://fedorahosted.org/389/attachment/ticket/47910/0001-Ticket-47910-allow-logconv.pl-S-E-switches-to-work-e.2.patch</a><br>
          <br>
          I request for your valuable feedback. <br>
        </blockquote>
        Hi Amita,<br>
        <br>
        Thanks for writing a lib389 test!  I do have some comments, see
        below...<br>
        <br>
        In function log_dir:<br>
        <br>
        First, you are using the DATA directory for temporary storage,
        you should be using the TMP dir - this way the contents are
        removed for you before the next test runs.<br>
        <br>
        ldif_file = topology.standalone.getDir(__file__, TMP_DIR) +
        "ticket47910.ldif" <br>
        <br>
-------------------------------------------------------------------------------------------------------------------------------------<br>
        Note, for future tests, if you need to store files permanently,
        they should be in subdirectories of DATA:<br>
        <br>
            getDir(__file__, DATA_DIR) + "/ticket47910/ticket47910.ldif"
        <br>
-------------------------------------------------------------------------------------------------------------------------------------<br>
        <br>
        Next in log_dir<br>
        <br>
        You are generating an ldif file, and then importing it for each
        test function.  This seems excessive for trying to generate
        logging.   The only thing that is logged is the adding of the
        task entry.  So like 6 lines of logging.  It would be
        easier/faster to just do a single search.  You can also disable
        access log buffering so you don't have to wait for the logging
        to be written to disk.<br>
        <br>
        There is a shortcut function for setting access log buffering:<br>
        <br>
        topology.standalone.setAccessLogBuffering (False)<br>
        <br>
        You still need to sleep for 1 second, but it's a lot better than
        50 seconds.<br>
        <br>
        The rest looks good.<br>
      </blockquote>
      Thanks Mark.<br>
      <br>
      Here is the update patch ::
      <a moz-do-not-send="true" class="moz-txt-link-freetext"
href="https://fedorahosted.org/389/attachment/ticket/47910/0001-Ticket-47910-allow-logconv.pl-S-E-switches-to-work.patch">https://fedorahosted.org/389/attachment/ticket/47910/0001-Ticket-47910-allow-logconv.pl-S-E-switches-to-work.patch</a><br>
    </blockquote>
    Thanks Amita,<br>
    <br>
    Looks good, ack!<br>
    <br>
    Mark<br>
    <blockquote cite="mid:55C4A87E.6040500@redhat.com" type="cite"> <br>
      Regards,<br>
      Amita<br>
      <blockquote cite="mid:55C35662.8040605@redhat.com" type="cite"> <br>
        Thanks,<br>
        Mark<br>
        <blockquote cite="mid:55C335C3.70105@redhat.com" type="cite"> <br>
          Thanks &amp; Regards, <br>
          Amita <br>
          -- <br>
          389-devel mailing list <br>
          <a moz-do-not-send="true" class="moz-txt-link-abbreviated"
            href="mailto:389-devel@lists.fedoraproject.org">389-devel@lists.fedoraproject.org</a>
          <br>
          <a moz-do-not-send="true" class="moz-txt-link-freetext"
            href="https://admin.fedoraproject.org/mailman/listinfo/389-devel">https://admin.fedoraproject.org/mailman/listinfo/389-devel</a><br>
        </blockquote>
        <br>
        <br>
        <fieldset class="mimeAttachmentHeader"></fieldset>
        <br>
        <pre wrap="">--
389-devel mailing list
<a moz-do-not-send="true" class="moz-txt-link-abbreviated" href="mailto:389-devel@lists.fedoraproject.org">389-devel@lists.fedoraproject.org</a>
<a moz-do-not-send="true" class="moz-txt-link-freetext" href="https://admin.fedoraproject.org/mailman/listinfo/389-devel">https://admin.fedoraproject.org/mailman/listinfo/389-devel</a></pre>
      </blockquote>
      <br>
      <br>
      <fieldset class="mimeAttachmentHeader"></fieldset>
      <br>
      <pre wrap="">--
389-devel mailing list
<a class="moz-txt-link-abbreviated" href="mailto:389-devel@lists.fedoraproject.org">389-devel@lists.fedoraproject.org</a>
<a class="moz-txt-link-freetext" href="https://admin.fedoraproject.org/mailman/listinfo/389-devel">https://admin.fedoraproject.org/mailman/listinfo/389-devel</a></pre>
    </blockquote>
    <br>
  </body>
</html>