[PATCH] _umountall unmounts everything

Paul Howarth paul at city-fan.org
Wed Aug 11 14:03:12 UTC 2010


On 11/08/10 14:26, Alan Franzoni wrote:
> Hello,
> I had already submitted that to the bug tracker and I though it was
> approved, but I think it didn't get applied:
>
> http://fedorahosted.org/mock/ticket/4
>
> I've got it updated to work with the current master and to solve an
> issue with tmpfs as well. I'm attaching it as well.
>
> this should address Paul Howarth patch 2/5 as well; it seems pointless
> to me to reverse a structure and then reverse it again after using it,
> it's better to have a copy of it reversed "on the fly" when using it.
>
> BTW, Paul, how many times is _umountall() called in your code? I thought
> it ought to be called just once!

First time is at the end of the "running yum" state, after setting up 
the rpm build directories, and the second time is after copying the 
build packages to the results directory.

Paul.


More information about the buildsys mailing list