email notifications

Toshio Kuratomi a.badger at gmail.com
Fri Aug 20 15:23:05 UTC 2010


On Fri, Aug 20, 2010 at 05:06:33PM +0300, Ville Skyttä wrote:
> On Friday 13 August 2010, Toshio Kuratomi wrote:
> > On Wed, Aug 04, 2010 at 09:12:16AM +0300, Ville Skyttä wrote:
> > > 
> > > Ping?  Still no notification mails for me, for example the modplugtools
> > > builds done yesterday, and I haven't seen any comments when this might
> > > get fixed.
> > 
> > I know practically nothing about the koji code but that code seems very
> > wrong.  This is earlier in the class:: [...]
> 
> Thanks for taking the time to look into this.  Maybe some changes have been 
> made already - at least I received a build failure mail from today for a 
> failed javasqlite build.  I didn't receive one for example for successful 
> seeker and rpmlint builds yesterday though :(

dgilmore says that we haven't applied any changes to the koji running in
Fedora Infrastructure but that he needs to pull in a patch to hotfix our
instance with.  Since I didn't see a patch in the upstream git repository,
I'm attaching one here.

-Toshio
-------------- next part --------------
From a3c0248a10c5ddbe9a34f76b995fbf10c34e87f5 Mon Sep 17 00:00:00 2001
From: Toshio Kuratomi <toshio at fedoraproject.org>
Date: Fri, 20 Aug 2010 11:17:43 -0400
Subject: [PATCH] Fix Unicode traceback with notification email.

---
 builder/kojid |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/builder/kojid b/builder/kojid
index 2f7f480..77ded36 100755
--- a/builder/kojid
+++ b/builder/kojid
@@ -3455,7 +3455,10 @@ Status: %(status)s\r
 
         message = self.message_templ % locals()
         # ensure message is in UTF-8
-        message = message.encode('utf-8')
+        if isinstance(message, unicode):
+            message = message.encode('utf-8')
+        else:
+            message = unicode(message, encoding='utf8', errors='replace').encode('utf8')
 
         server = smtplib.SMTP(options.smtphost)
         #server.set_debuglevel(True)
-- 
1.7.2.1

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
Url : http://lists.fedoraproject.org/pipermail/buildsys/attachments/20100820/1adf46ad/attachment.bin 


More information about the buildsys mailing list