[PATCH] Run yum commands without shell, as sequences instead of strings.

Ville Skyttä ville.skytta at iki.fi
Mon Mar 7 20:27:16 UTC 2011


On 03/07/2011 10:17 PM, Ville Skyttä wrote:
> Fixes shell escaping issues like in '--install "perl(Foo::Bar)"'.  The
> "canonical" syntax for chroot_setup_cmd in configs is now a tuple or a
> list, but a string is still accepted for backwards compatibility (it
> gets split to list internally).

Posted here for comments before committing.  The patch touches many 
files but is not actually that scary and should be backwards compatible 
[1].  I've been using this locally for a quite a while and found no 
problems, and it fixes the above mentioned cases for me.

The *.cfg changes should be safe to be left out of the patch if people 
think it's better to avoid potential *.rpmnew config file churn for 
fairly cosmetic reasons for now.  Either way, old config files should 
continue to work as-is anyway (in fact I've been running this with such 
old config files all the time).

[1] Except that preExistingDeps is now a list whereas it used to be a 
string, but the only occurrence of its usage I'm aware of was in the 
ccache plugin and that's addressed in the patch.


More information about the buildsys mailing list