[PATCH] builder: Upload recursively all files in all subdirs

[Mathieu Bridon]

On Wed, 2013-10-02 at 19:16 -0400, Mike McLean wrote:
> On 10/02/2013 04:00 AM, Mathieu Bridon wrote:
> > ---
> > This will become necessary if we want to upload the results of a mash
> > task, as I am currently working on.
> >
> > Should I have created a new uploadDirRecursively() method, instead of
> > changing uploadDir()?
> 
> It should probably be an optional flag rather than a change to default 
> behavior.

I wonder, uploadDir seems to not be used anywhere else?

> It might be simpler if you used os.walk instead of os.path.walk.

Slightly, but not that much.

However, I just realized that os.path.walk is considered deprecated (in
favour of os.walk) and has been removed from Python 3.

So yes, I'll replace that in the next version of the patch.

> I don't think you need to do anything in the os.path.isdir case, unless 
> you intend to prune the walk.

Hah, that TODO is a leftover from when I was writing the code, I forgot
to remove it. Sorry about that.


-- 
Mathieu