[PATCH] enhancements to rpkg

Mike Bonnet mikeb at redhat.com
Wed Nov 12 18:11:31 UTC 2014


On 10/30/14 1:21 PM, Mike Bonnet wrote:
> Hi.  Attached are a couple of enhancements to rpkg.  The first adds a
> --runas option.  This allows you to run Koji commands as a different
> user, if the Koji hub has been configured to allow you to do so.  This
> is useful for automation that launches builds on behalf of other users.
>   The other patch fixes support for password authentication (it has
> never worked correctly) and cleans up Koji session creation, so all
> relevant config options are passed through to the new session.  This
> should improve compatibility between the Koji cli and rpkg.  Let me know
> if there are any questions.

It came to my attention that these patches broke fedpkg because it 
passes keyword args as positional args.  This patch to fedpkg fixes 
that, which should make enhancing rpkg and fedpkg easier in the future.

-------------- next part --------------
From fc65d2d081b64d89183ff7220292a02d8a3dad5e Mon Sep 17 00:00:00 2001
From: Mike Bonnet <mikeb at redhat.com>
Date: Wed, 12 Nov 2014 12:57:03 -0500
Subject: [PATCH] pass keyword args as keyword args

---
 src/fedpkg/__init__.py |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/src/fedpkg/__init__.py b/src/fedpkg/__init__.py
index 4e389d5..3aeecc5 100644
--- a/src/fedpkg/__init__.py
+++ b/src/fedpkg/__init__.py
@@ -32,7 +32,8 @@ class Commands(pyrpkg.Commands):
         super(Commands, self).__init__(path, lookaside, lookasidehash,
                                        lookaside_cgi, gitbaseurl, anongiturl,
                                        branchre, kojiconfig, build_client,
-                                       user, dist, target, quiet)
+                                       user=user, dist=dist, target=target,
+                                       quiet=quiet)
 
         # New data
         self.secondary_arch = {
-- 
1.7.1


More information about the buildsys mailing list