[PATCH] enhancements to rpkg

[Dennis Gilmore]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Wed, 12 Nov 2014 17:17:17 -0800
Mike Bonnet <mikeb at redhat.com> wrote:

> On 11/12/14 5:06 PM, Dennis Gilmore wrote:
> > -----BEGIN PGP SIGNED MESSAGE-----
> > Hash: SHA1
> >
> > On Wed, 12 Nov 2014 10:11:31 -0800
> > Mike Bonnet <mikeb at redhat.com> wrote:
> >
> >> On 10/30/14 1:21 PM, Mike Bonnet wrote:
> >>> Hi.  Attached are a couple of enhancements to rpkg.  The first
> >>> adds a --runas option.  This allows you to run Koji commands as a
> >>> different user, if the Koji hub has been configured to allow you
> >>> to do so.  This is useful for automation that launches builds on
> >>> behalf of other users. The other patch fixes support for password
> >>> authentication (it has never worked correctly) and cleans up Koji
> >>> session creation, so all relevant config options are passed
> >>> through to the new session.  This should improve compatibility
> >>> between the Koji cli and rpkg.  Let me know if there are any
> >>> questions.
> >>
> >> It came to my attention that these patches broke fedpkg because it
> >> passes keyword args as positional args.  This patch to fedpkg fixes
> >> that, which should make enhancing rpkg and fedpkg easier in the
> >> future.
> >>
> >
> > nak, we need to do this without changing the api, there is other
> > users of rpkg outside of our control, we can not go changing the
> > API on them and breaking their clients. rpkg needs to be changed
> > without changing the API
> 
> I didn't think the order of kwargs was part of the API.  If fedpkg
> was using the API correctly, order wouldn't matter.

Too early in the day here, you're right. we should fix up fedpkg 

Dennis
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBAgAGBQJUZBAsAAoJEH7ltONmPFDRhXoP/0BzFU2WXbErLTF2gn+Ep5NR
efaCDkqWjZMvc08evHAVQzM/UQGikZSd/nT2RblNRBf7P7nWU5OwhkqKa0S2yz23
oNjUIRRXVP7koBhCDNNRJGVefz237eE/XTRKUAk1iyZRmS6tbctRYokS7lThrFII
UgaPy642CM02wrRbiHaB2T7bHoV64U6LsR/uis/VMCqu9PNhB+vb4GWREYfoM+xS
d0LmekN0fPMbweAb3jTcSHQsLx37TkpsogDbeG9Z1IWWasAIai3LNobOHLCa2m7e
m68SlusundhlESaeEzWKsxmrvtuVxdMTOfc0D8qqR5/Et55dgZfBRM/ZAW/pNJtC
0/CaSEYQRpiBI+gyhPpW5s3lGYhQzdRZ+/0nAP9IplTjSguYmeiVjhLBnLqsObyI
rhdyx+BAYvBXqnfUnSAbeiz0qCN1JOv0f7oinDLMg93D0vv2/diH0+KEf6JuZ3Cl
mt2uoze35RRlbH72GeZAYLt7QFBFHNOrRnDYrN4ZHGIba2hnTcyHYrJR5kskSWZs
vvfBuLfaa1bKOEBqlPiVYhPFvqyd3epK/UBbtAjzV+vuFYpBqf5R7nyFJ2V+M26S
G7pECki0wK0PFEMbE+fdTBtVZ+bxeIWVtE3RbepPw5YjlsmSixo4hzasbqPCEbqw
Glyjs6DJrKZ3hlQPUl1F
=uqfC
-----END PGP SIGNATURE-----