[PATCH] enhancements to rpkg
Pavol Babincak
pbabinca at redhat.com
Thu Nov 13 16:31:32 UTC 2014
On 10/30/2014 09:21 PM, Mike Bonnet wrote:
> Hi. Attached are a couple of enhancements to rpkg. The first adds a
> --runas option. This allows you to run Koji commands as a different
> user, if the Koji hub has been configured to allow you to do so. This
> is useful for automation that launches builds on behalf of other users.
Looks ok. Applied.
> The other patch fixes support for password authentication (it has never
> worked correctly) and cleans up Koji session creation, so all relevant
> config options are passed through to the new session. This should
> improve compatibility between the Koji cli and rpkg. Let me know if
> there are any questions.
I'm not sure about this patch. You modified "defaults" dictionary:
- removed pkgurl key,
- changed type and value of krbservice
Are we sure this won't break clients which might depend on this?
--
Pavol Babincak
Release Engineering, Red Hat
More information about the buildsys
mailing list