[PATCH] Mock autosigning

Miroslav Suchy msuchy at redhat.com
Fri Apr 17 17:18:57 UTC 2015


On 04/16/2015 07:24 PM, Julien Ballet wrote:
> I’m resending this patch since the last time it was not correctly tagged
> and then didn’t get reviewed in a long time.
> 
> This patch adds a small plugin (disabled by default) to call an
> arbitrary command on successful build passing the builts rpms as an
> argument. The main goal here being auto-signing of packages.

First it does not apply cleanly. Please rebase on mater and send output of
 git format-patch HEAD~1
instead of
 git show


Anyway I resolved two conflicts there manually, but I am getting;
  You must set "%_gpg_name" in your macro file
Despite the fact that I have it in my
  ~/.rpmmacros
despite the fact I put it into
  config_opts['macros']['%_gpg_name'] = "msuchy"
in site-defaults.cfg

Another problem can be, that the plugin is executed as root.
You may want to call
  self.uid_manager.dropPrivsTemp()
before calling do()
and then:
  self.buildroot.uid_manager.restorePrivs()

Right now it is not working for me. Can you elaborate how to make it
functional or fix the code please?

Mirek


More information about the buildsys mailing list