Hi there,<br> A couple of comments.<br><br>On Tue, Feb 19, 2013 at 1:58 PM, Kashyap Chamarthy <span dir="ltr"><<a href="mailto:kchamart@redhat.com" target="_blank">kchamart@redhat.com</a>></span> wrote:<br><div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">A couple of small additions:<br>
- Add a PTY serial console, so that "virsh console foo" works out of the box<br>
(once the guest is installed).<br></blockquote><div><br>What's the benefit of doing it this way over using the <console> XML? I thought they would both enable the serial stuff, but maybe I'm wrong.<br>
</div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
- Use a UNIX domain socket server (for better security) as a character<br>
device instead of a TCP port.<br></blockquote><div><br>I'm not opposed to this in principle, though I think we probably need more work to make it work properly. In particular, I'm pretty sure "_wait_for_guest_boot" will have to be modified to listen over the unix domain socket instead of the listen_port (at which point we can remove the listen_port completely). You can test it out by running oz-install with -u or -g to do customization/icicle generation, respectively.<br>
</div>Thanks,<br>Chris<br></div>