memcpy overlap: quickly detect, diagnose, work around

Matt McCutchen matt at mattmccutchen.net
Mon Nov 29 23:44:37 UTC 2010


On Sun, 2010-11-28 at 15:13 -0800, John Reiser wrote:
> This patch (with .rpms for x86_64 and i686) enables glibc optionally
> to detect, diagnose, and work around overlap in memcpy/mempcpy:
>     http://bitwagon.com/glibc-memlap/glibc-memlap.html

What is the mass addition of commented curly braces for?  It is
distracting from the substance of the patch.

diff --git a/sysdeps/x86_64/multiarch/strcmp.S b/sysdeps/x86_64/multiarch/strcmp.S
index 1859289..e014283 100644
--- a/sysdeps/x86_64/multiarch/strcmp.S
+++ b/sysdeps/x86_64/multiarch/strcmp.S
@@ -21,7 +21,7 @@
 #include <sysdep.h>
 #include <init-arch.h>
 
-#ifdef USE_AS_STRNCMP
+#ifdef USE_AS_STRNCMP  /*{*/
 /* Since the counter, %r11, is unsigned, we branch to strcmp_exitz
    if the new counter > the old one or is 0.  */
 # define UPDATE_STRNCMP_COUNTER				\

(etc.)

-- 
Matt



More information about the devel mailing list