About the rename of restore-trash in trash-cli package

Ankur Sinha sanjay.ankur at gmail.com
Sun Apr 10 14:07:28 UTC 2011


Hello Andrea,

On Sun, 2011-04-10 at 15:39 +0200, Andrea Francia wrote:
> Dear Fedora developers,
>    I'm the upstream developer of trash-cli.
> I saw in package announce[1] that you decided to change of
> restore-trash into trash-restore.
> I appreciate your work but in this case I'm not happy with one of the
> last change. 
> 
> 
> I'm preparing [4] a program called trash-restore to be included in
> trash-cli that would behave in a different way that restore-trash. So
> your decision could cause me problems.
> 
> 
> I'd better liked if this type of change will be discussed with me
> before to be implemented in a so famous distribution.
> 
> 
> In the time that was published it was using these command names:
>  - trash (for trashing a file)
>  - empty-trash (for empty the trashcan)
>  - list-trash (for listing the contents of the trashcan)
>  - restore-trash (for put back a trashed file)
> 
> 
> I was happy about my command name choice as the packagers of Debian
> and Ubuntu were. So they packaged my application for
> those distributions.
> 
> 
> Instead, during the first packaging for Fedora, some problems happen.
> The name 'trash' wasn't accepted by the package reviewer so after a
> long discussion (see [2], and [3]) and I end up to change the names
> into: trash-put, trash-empty, trash-list. But I left alone
> restore-trash for reserving trash-restore for future development as
> described in the wiki [4]. 

The name change was only temporary. Once you release a new version, I
can rectify this with the update that I push (it's one line in the
spec). I really wasn't aware that you weren't using it because you had
it reserved for future use. I did file a ticket on the trac before
implementing this change (which was closed with a WONTFIX). If you'd
like, I could push an update to remove the name change, or I could do it
when you release a new version. Please do let me know. 

> 
> 
> All the trash-* are supposed to ben non interactive, the new
> trash-restore will be but the old restore-trash is not.
> 
> 
> Thank you
> 
> 
> [1]
> http://lists.fedoraproject.org/pipermail/package-announce/2011-March/057122.html
> [2]
> http://lists.fedoraproject.org/pipermail/devel/2008-October/011247.html
> [3] https://bugzilla.redhat.com/show_bug.cgi?id=448122
> [4] http://code.google.com/p/trash-cli/wiki/ProposedUserinterface
> 
> 
> -- 
> Andrea Francia
> 

Regards,
Thanks,
Ankur



More information about the devel mailing list