Question about commiting the sources

[Sergio Belkin]

2012/3/16 Bryn M. Reeves <bmr at redhat.com>:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On 03/16/2012 02:33 PM, Jan Synacek wrote:
>> On 03/16/12 at 11:16am, Sergio Belkin wrote:
>>> Perhaps and stupid question:
>>>
>>> After upload new-sources to repo, it outputs: Uploaded and added
>>> to .gitignore: Source upload succeeded. Don't forget to commit
>>> the sources file
>>>
>>> I don't understand! By default it add sources files to .gitignore
>>> and then it asks for commit them?
>>>
>>> Is it something that I misunderstood?
>>>
>>
>> It just tells you not to forget to commit the file named 'sources'.
>> The file changes when you execute new-sources and should be
>> commited, because it contains an md5sum of the source tarball.
>>
>> The message is somewhat misleading, because the 'sources' file gets
>> staged automatically after new-sources, so if you do fedpkg commit,
>> it gets commited anyway.
>
> It's also a bit unclear in that the thing that was added to .gitignore
> is the tarball file name (you don't want to check it into the VCS -
> that's what the lookaside is for). Maybe it would be more explicit to
> output a line like:
>
>  Uploaded and added "fooble-1.2.3-rc3-git1.tar.gz" to .gitignore:
>
> Should be a quick & simple patch.
>
> Regards,
> Bryn.
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.12 (GNU/Linux)
> Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
>
> iEYEARECAAYFAk9jUWsACgkQ6YSQoMYUY95kswCgvJTVh/o5YSeY/Bv6sfOSKLwC
> 7BAAnA3N+i0zu9rL3BzY0D501OfTk5nL
> =lrjK
> -----END PGP SIGNATURE-----
> --
> devel mailing list
> devel at lists.fedoraproject.org
> https://admin.fedoraproject.org/mailman/listinfo/devel

+1

-- 
--
Sergio Belkin  http://www.sergiobelkin.com
Watch More TV http://sebelk.blogspot.com
LPIC-2 Certified - http://www.lpi.org