macros.cmake: set -DCMAKE_BUILD_TYPE=ReleaseWithDebInfo by default

[Ralf Corsepius]

On 11/13/2012 05:05 AM, Richard Shaw wrote:
> On Mon, Nov 12, 2012 at 4:46 PM, Rex Dieter <rdieter at math.unl.edu
> <mailto:rdieter at math.unl.edu>> wrote:
>
>     See also,
>     https://bugzilla.redhat.com/show_bug.cgi?id=875954
>
>     orionp and I were discussing on irc today, the idea to add
>     -DCMAKE_BUILD_TYPE=ReleaseWithDebInfo
>     to %cmake by default in /etc/rpm/macros.cmake , while making it easy to
>     set/override manually, similar to how %_cmake_lib_suffix64 is currently
>     handled.
>
>     the idea being that many cmake projects default to Release (or not,
>     sometimes goofy things like Debug)
>
>     The idea being that many projects default to
>     CMAKE_BUILD_TYPE=Release and
>     end up pulling in -O3 (and -DNDEBUG).
>
>     There's 2 issues we'd like some wider input.  What disadvantages or
>     side-
>     effects are there to:
>
>     1.  setting a default CMAKE_BUILD_TYPE?
>
>     2.  building with -DNDEBUG by default?
>
>
> I own several packages that use cmake and I've taken to setting the
> release type to RelWithDebugInfo like you suggest. One question I've had
> but never gotten around to asking is: Regardless of whether you use
> Release or RelWithDebugInfo, should we be building with -O3? It seems
> odd that the rpm macro defaults to doing something that is explicitly
> against the packaging guidelines.

Your sentence confuses me or I am missing somthing.

The FPG intention is to mandate using RPM_OPT_FLAGS. These so far have 
contained -O2. So, unless something has recently been changed, using -O3 
would qualify as a bug somewhere.

Ralf