gammaray includes qt-everywhere-opensource-src-4.8.5.tar.gz

[Daniel Vrátil]

On Saturday 14 of December 2013 19:21:14 Michael Schwendt wrote:
> > Source1:       
> > http://releases.qt-project.org/qt4/source/qt-everywhere-opensource-src-%{
> > qt_version}.tar.gz
> > 
> > BuildRequires:  qt-devel
> > BuildRequires:  qt-devel-private
> > 
> > %cmake .
> > -DQT_PRIVATE_INCLUDE_DIR=%{_builddir}/qt-everywhere-opensource-src-%{qt_v
> > ersion}/include/QtCore
> The package review request was: https://bugzilla.redhat.com/905615
> 
> Nowhere is a comment that explains why the 230MB Qt source is included
> and used to build GammaRay. Isn't qt-devel-private sufficient?

Hi

it's documented in the very first comment:

"The package needs Qt sources in order to have access to some private headers 
and sources that are not available in qt-devel and qt-devel-private"

AFAIK this was necessary to get access to QPainter internals for painter 
introspection, and to build against the harfbuzz shipped with Qt sources.

Cheers,
Dan

-- 
Daniel Vrátil
KDE Desktop Team
Associate Software Engineer, Red Hat, Inc.

GPG Key: 0xC59D614F6F4AE348
Fingerprint: 4EC1 86E3 C54E 0B39 5FDD B5FB C59D 614F 6F4A E348
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.fedoraproject.org/pipermail/devel/attachments/20131214/fd08e80b/attachment.sig>