Package reviev : tayga

[Alexey I. Froloff]

On Wed, Nov 06, 2013 at 05:14:22PM +1030, William Brown wrote:
> I have attached the SRPM of what I have created.
I just figured, that you are asking questions before actually
creating review request...

> Should the ifup/ifdown script generate the tayga.conf on the fly to
> say /var/run/tmp somewhere from values provided in the ifup / ifdown?
Better configure NAT64 in ifcfg-* files and generate tayga.conf.
That approach worked in OpenWRT ;-)

Don't forget, that it is possible to configure static V4-V6
mappings.  It could be placed into /e/s/n-s/nat64-$DEVICE file or
whatsoever.

Avoid using "REALDEVICE" variable - it is being used somewhere
inside network-scripts.

You still have hardcoded "nat64" interface name in ifdown-nat64
script.

> Additionally, what I have in these scripts should really be reviewed, as
> I have never written them before.
I can help with that if you test it - I only have tayga on
OpenWRT box.

> Finally, tayga is a long running process, as such, I have enabled the
> hardened build. It is possible to run as an alternate user and in a
> chroot of it's DB dir. What is the best way to go about adding a user
> for this package for the daemon to run as?
This is described here - https://fedoraproject.org/wiki/Packaging:UsersAndGroups

Also, take a look at other packages, like qemu-common.

-- 
Regards,    --
Sir Raorn.   --- http://thousandsofhate.blogspot.com/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: Digital signature
URL: <http://lists.fedoraproject.org/pipermail/devel/attachments/20131106/73a90343/attachment.sig>