I am not reviewer but I think it make sense following things are good to incorporate<div><br></div><div>>><span class="Apple-style-span" style="font-family:monospace;white-space:pre-wrap"># These packages are not require for python >=2.6 but required for python = 2.5</span></div>
<div><pre style="word-wrap:break-word;white-space:pre-wrap">>>Requires: python >= 2.5</pre><pre style="word-wrap:break-word;white-space:pre-wrap"><font class="Apple-style-span" size="4">I think your Requires: must be python = 2.5</font></pre>
<pre style="word-wrap:break-word;white-space:pre-wrap">>>%setup -q -n cloud-%version</pre><pre style="word-wrap:break-word;white-space:pre-wrap"><font class="Apple-style-span" size="4">is that version should be %{version}</font></pre>
<pre style="word-wrap:break-word;white-space:pre-wrap">>> mkdir -p ...</pre><pre style="word-wrap:break-word;white-space:pre-wrap">>>cp -p ...</pre><pre style="word-wrap:break-word;white-space:pre-wrap"><font class="Apple-style-span" size="4">It will be good if you make use of macro like %{__cp}</font></pre>
<pre style="word-wrap:break-word;white-space:pre-wrap"><br></pre><pre style="word-wrap:break-word;white-space:pre-wrap"><br></pre><pre style="word-wrap:break-word;white-space:pre-wrap">;)</pre></div><div>V!jay <br><br><div class="gmail_quote">
On Mon, Mar 5, 2012 at 1:00 AM, Amit Saha <span dir="ltr"><<a href="mailto:droidery@gmail.com">droidery@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hello:<br>
<br>
Could someone please review my first package: <a href="https://bugzilla.redhat.com/show_bug.cgi?id=799810" target="_blank">https://bugzilla.redhat.com/<u></u>show_bug.cgi?id=799810</a> ?<br>
<br>
Since, this is my first, I am in need of a sponsor (FAS: amitksaha)<br>
<br>
Thanks a lot !<br>
-Amit<span class="HOEnZb"><font color="#888888"><br>
-- <br>
<a href="http://echorand.me" target="_blank">http://echorand.me</a><br>
-- <br>
devel mailing list<br>
<a href="mailto:devel@lists.fedoraproject.org" target="_blank">devel@lists.fedoraproject.org</a><br>
<a href="https://admin.fedoraproject.org/mailman/listinfo/devel" target="_blank">https://admin.fedoraproject.<u></u>org/mailman/listinfo/devel</a></font></span></blockquote></div><br></div>