<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">Hello,<br><br></div><div class="gmail_quote">BuildRoot is only needed for EPEL5: <a href="https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag">https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag</a><br>
</div><div class="gmail_quote">If presents, it should be one of those: <a href="http://fedoraproject.org/wiki/EPEL:Packaging#BuildRoot_tag">http://fedoraproject.org/wiki/EPEL:Packaging#BuildRoot_tag</a><br><br></div><div class="gmail_quote">
Removing BuildRoot and "clean" section are needed only for EPEL5 so I think it would better to preserve conditionals.<br></div><div class="gmail_quote">Also, the conditionals there can be simplified: <a href="http://fedoraproject.org/wiki/Packaging:DistTag#Conditionals">http://fedoraproject.org/wiki/Packaging:DistTag#Conditionals</a><br>
<br>%{?el5:BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root}<br>...<br>%if 0%{?el5}<br>%clean<br>rm -rf %{buildroot}<br>%endif<br><br></div><div class="gmail_quote">-- as examples.<br></div><div class="gmail_quote">
<br>---<br></div><div class="gmail_quote">wbr, Denis.<br></div><div class="gmail_quote"><br>On Wed, Feb 19, 2014 at 5:13 AM, David Roheim <span dir="ltr"><<a href="mailto:david.roheim@gmail.com" target="_blank">david.roheim@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div>Hi Pavol,<br><br>I can not approve your package, but I would suggest some things.<br>
<br>* Bump your rev version. Incl. changelog.<br><span style="font-family:verdana,sans-serif">* Define your BuildRoot<br>
* Use %{_bindir} instead of /usr/bin<br></span></div><span style="font-family:verdana,sans-serif">* Source-format your spec-file<br></span><div><span style="font-family:verdana,sans-serif"><br>Why do you have:<br><br>%if 0%{?rhel} && 0%{?rhel} <= 5<br>
rm -rf %{buildroot}<br>%endif<br><br>Why not just:<br>rm -rf $RPM_BUILD_ROOT<br></span><br><br></div><div>Nice page: <a href="https://fedoraproject.org/wiki/Packaging:RPMMacros" target="_blank">https://fedoraproject.org/wiki/Packaging:RPMMacros</a><br>
<br></div><div>Anyways :)<br><br></div><div>David<br></div><div><div><div><div><div><br></div></div></div></div></div></div><div class="gmail_extra"><br clear="all"><div><div dir="ltr"><div><div><div><b>David Roheim</b><br>
</div><a href="mailto:david.roheim@gmail.com" target="_blank">david.roheim@gmail.com</a> - <a href="http://roheim.org/" target="_blank">http://roheim.org/</a><br></div></div><br></div></div>
<br><br><div class="gmail_quote">On Tue, Feb 18, 2014 at 9:41 PM, Pavol Ipoth <span dir="ltr"><<a href="mailto:pavol.ipoth@gmail.com" target="_blank">pavol.ipoth@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div dir="ltr">Hi,<br><br>can please somebody approve my package, it was already reviewed but reviewer doesn't have permissions to approve new package. Can somebody look at it. Thanks.<br><br><a href="https://bugzilla.redhat.com/show_bug.cgi?id=1058038" target="_blank">https://bugzilla.redhat.com/show_bug.cgi?id=1058038</a><span class=""><font color="#888888"><br>
</font></span></div><span class=""><font color="#888888">
</font></span><br></blockquote></div></div></blockquote></div><br></div></div>