<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">2014-04-28 0:02 GMT+02:00 Andrew Price <span dir="ltr"><<a href="mailto:anprice@redhat.com" target="_blank">anprice@redhat.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
On 24/04/14 15:13, Lennart Poettering wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
We probably should make setjmp()-freeness a requirement for<br>
all code included in Fedora.<br>
</blockquote>
<br>
Would it be worth the effort, and how feasible is it anyway?<br></blockquote><div><br></div></div>Generally no. Been there, done that. <br><br>Avoiding setjmp() involves touching well over 75% lines of affected code to add explicit alternative return paths. The result might be cleaner but this is so radical a change that it is also very likely to introduce new bugs. As far as cleanups go, this is on the very end of the "you'd be crazy to do it in Fedora other than doing it upstream and rebasing" scale.<br>
<br></div><div class="gmail_extra">(OTOH if the code is using setjmp() <i>and</i> also using it incorrectly, there's no other practical thing to do than to do such a huge line-by-line rewrite.)<br></div><div class="gmail_extra">
Mirek<br></div></div>