<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">On 06/18/2014 02:16 PM, Adam Jackson
wrote:<br>
</div>
<blockquote cite="mid:1403115409.5741.15.camel@dmt" type="cite">
If I may vent for a moment, I'd like to point out exactly how
spurious
the blocks usage was (and, implicitly, troll for code review):
</blockquote>
<blockquote cite="mid:1403115409.5741.15.camel@dmt" type="cite"><a class="moz-txt-link-freetext" href="http://pkgs.fedoraproject.org/cgit/hfsplus-tools.git/plain/hfsplus-tools-no-blocks.patch">http://pkgs.fedoraproject.org/cgit/hfsplus-tools.git/plain/hfsplus-tools-no-blocks.patch</a>
</blockquote>
<blockquote cite="mid:1403115409.5741.15.camel@dmt" type="cite">That's
right kids, the C89 version is less code even _before_ you count
the actual Blocks runtime.<br>
</blockquote>
I should know better than start an argument about programming with
you, but isn't your patch leaking memory? I don't know how often
hfsplus tools allocate ctx->preMessage but just overwriting the
pointer seems off. At least a comment, maybe?<br>
<pre>- if (bp)
- ctx->postMessage = (fsckBlock_t)Block_copy(bp);
+ /* possible memory leak: unlinking old postMessage */
+ ctx->postMessage = bp;</pre>
</body>
</html>