<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Wed, Jul 8, 2015 at 10:15 AM, Antonio Trande <span dir="ltr"><<a href="mailto:anto.trande@gmail.com" target="_blank">anto.trande@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">-----BEGIN PGP SIGNED MESSAGE-----<br>
Hash: SHA256<br>
<div><div class="h5"><br>
On 07/08/2015 07:08 PM, Dave Johansen wrote:<br>
> I have two reviews that have been waiting for a reviewer for a<br>
> while. I would be willing to do a review swap but I would probably<br>
> have a slow turn around on my end (I'm currently on vacation and<br>
> only occasionally get time to do this sort of thing). So if you're<br>
> willing to swap or do the review, then please let me know.<br>
> cppformat: <a href="https://bugzilla.redhat.com/show_bug.cgi?id=1216279" rel="noreferrer" target="_blank">https://bugzilla.redhat.com/show_bug.cgi?id=1216279</a><br>
> hgsubversion: <a href="https://bugzilla.redhat.com/show_bug.cgi?id=1221459" rel="noreferrer" target="_blank">https://bugzilla.redhat.com/show_bug.cgi?id=1221459</a><br>
> Thanks, Dave<br>
><br>
><br>
<br>
</div></div>I'm willing to review both your packages.<br>
<br>
<a href="https://bugzilla.redhat.com/show_bug.cgi?id=1231427" rel="noreferrer" target="_blank">https://bugzilla.redhat.com/show_bug.cgi?id=1231427</a><span class=""></span></blockquote><div><br></div><div>It looks like these two lines are unused and are causing problems because qmake isn't available when they're run:<br>%global qtinc %(qmake -query QT_INSTALL_PREFIX)/include<br>%global qtlib %(qmake -query QT_INSTALL_PREFIX)/lib<br></div></div></div></div>