[EPEL-devel] epel-release: consider adding %epel macro ?

Rex Dieter rdieter at math.unl.edu
Tue Nov 11 20:00:18 UTC 2014


Jeff Sheltren wrote:

> On Fri, Oct 31, 2014 at 5:42 AM, Rex Dieter
> <rdieter at math.unl.edu> wrote:
> 
>> Rex Dieter wrote:
>>
>> > +%epel %{?rhel}%{!?:rhel:7}
>>
>> typo alert ^^ (in the second part), but hopefully you get the idea.
>>
>> Or, if you'd rather not depend on %rhel macro, and just hard-code to 7,
>> that
>> would be fine too.
>>
> 
> 
> The approach looks good to me.
> 
> The patch needs a little work though: besides the typo you mentioned, the
> install line is copying the wrong SOURCE file.
> 
> I see %rhel is present on CentOS -- I can't speak to other rebuilds
> though. It would be nice to verify that.
> 
> Bonus points for a second patch to remove all the extra trailing
> whitespace happening in this spec :)

OK (attached).

-- Rex
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-implement-epel-macro.patch
Type: text/x-patch
Size: 1605 bytes
Desc: not available
URL: <http://lists.fedoraproject.org/pipermail/epel-devel/attachments/20141111/a15980be/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-fix-trailing-whitespace.patch
Type: text/x-patch
Size: 1410 bytes
Desc: not available
URL: <http://lists.fedoraproject.org/pipermail/epel-devel/attachments/20141111/a15980be/attachment-0001.bin>


More information about the epel-devel mailing list