[Bug 858082] Review Request: mingw-qt5-qttranslations - Qt5 for Windows - QtTranslations component

[bugzilla at redhat.com]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=858082

--- Comment #4 from greg.hellings at gmail.com ---
$ rpmlint mingw-qt5-qttranslations.spec 
mingw-qt5-qttranslations.spec:26: W: macro-in-comment %{qt_module}
mingw-qt5-qttranslations.spec:26: W: macro-in-comment %{snapshot_rev}
mingw-qt5-qttranslations.spec:26: W: macro-in-comment %{qt_module}
mingw-qt5-qttranslations.spec:26: W: macro-in-comment %{snapshot_rev}
0 packages and 1 specfiles checked; 0 errors, 4 warnings.

$ rpmlint mingw-qt5-qttranslations-5.0.1-1.fc19.src.rpm 
mingw-qt5-qttranslations.src:26: W: macro-in-comment %{qt_module}
mingw-qt5-qttranslations.src:26: W: macro-in-comment %{snapshot_rev}
mingw-qt5-qttranslations.src:26: W: macro-in-comment %{qt_module}
mingw-qt5-qttranslations.src:26: W: macro-in-comment %{snapshot_rev}
1 packages and 0 specfiles checked; 0 errors, 4 warnings.

$ rpmlint results_mingw-qt5-qttranslations/5.0.1/1.fc18/mingw{32,64}*
mingw32-qt5-qttranslations.noarch: W: no-documentation
mingw32-qt5-qttranslations-debuginfo.noarch: E: empty-debuginfo-package
mingw64-qt5-qttranslations.noarch: W: no-documentation
mingw64-qt5-qttranslations-debuginfo.noarch: E: empty-debuginfo-package
4 packages and 0 specfiles checked; 2 errors, 2 warnings.

Since there is no binary portion to this package, it appears you should disable
building of the debuginfo packages.

$ rpm -q --requires mingw32-qt5-qttranslations
rpmlib(FileDigests) <= 4.6.0-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(PayloadIsXz) <= 5.2-1

$ rpm -q --requires mingw64-qt5-qttranslations
rpmlib(FileDigests) <= 4.6.0-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(PayloadIsXz) <= 5.2-1

$ rpm -q --provides mingw32-qt5-qttranslations
mingw32-qt5-qttranslations = 5.0.1-1.fc18

$ rpm -q --provides mingw64-qt5-qttranslations
mingw64-qt5-qttranslations = 5.0.1-1.fc18

$ wget --quiet
http://releases.qt-project.org/qt5/5.0.1/submodules_tar/qttranslations-opensource-src-5.0.1.tar.xz
-O - | md5sum 
de27f8384296e366e454754b69197634  -
$ md5sum qttranslations-opensource-src-5.0.1.tar.xz 
de27f8384296e366e454754b69197634  qttranslations-opensource-src-5.0.1.tar.xz


+ OK
! Needs to be looked into
/ Not applicable

[+] Compliant with generic Fedora Packaging Guidelines
[+] Source package name is prefixed with 'mingw-'
[+] Spec file starts with %{?mingw_package_header}
[+] BuildRequires: mingw32-filesystem >= 95 is in the .spec file
[+] BuildRequires: mingw64-filesystem >= 95 is in the .spec file
[+] Spec file contains %package sections for both mingw32 and mingw64 packages
[+] Binary mingw32 and mingw64 packages are noarch
[+] Spec file contains %{?mingw_debug_package} after the %description section
[+] Uses one of the macros %mingw_configure, %mingw_cmake, %mingw_cmake_kde4
    or %mingw_qmake_qt5 to configure the package
[+] Uses the macro %mingw_make to build the package
[+] Uses the macro %mingw_make to install the package
[!] If package contains translations, the %mingw_find_lang macro must be used
[+] No binary package named mingw-$pkgname is generated
[+] Libtool .la files are not bundled
[+] .def files are not bundled
[+] Man pages which duplicate native package are not bundled
[+] Info files which duplicate native package are not bundled
[+] Provides of the binary mingw32 and mingw64 packages are equal
[+] Requires of the binary mingw32 and mingw64 packages are equal

I believe the debug package can be suppressed as there is no binary code which
includes debug symbols here.

Additionally, this package is, by its very nature, a translations package. Yet
you're not using the find_lang macro. Does it not support .qm files? Does it
need to be updated to include these files as well, or are qm files considered
too app specific for that?

You note that the BR for mingw32-qt-qmake and mingw64-qt-qmake are "Temporary
until lrelease-qt5 is built." I don't see a native package for those yet, but I
see mingw{32,64}-qt5-qttools-lrelease. Is the native package built and ready
yet? If not, you might note what issue # will see it completed in the spec file
for sanity's sake.

The rest of the issues have been addressed elsewhere in mingw-qt5 reviews.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=FuCWbSl5Og&a=cc_unsubscribe