[Bug 858077] Review Request: mingw-qt5-qtsensors - Qt5 for Windows - QtSensors component

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=858077

greg.hellings at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |greg.hellings at gmail.com
           Assignee|nobody at fedoraproject.org    |greg.hellings at gmail.com
              Flags|                            |fedora-review?

--- Comment #4 from greg.hellings at gmail.com ---
$ rpmlint mingw-qt5-qtsensors.spec 
mingw-qt5-qtsensors.spec:26: W: macro-in-comment %{qt_module}
mingw-qt5-qtsensors.spec:26: W: macro-in-comment %{snapshot_rev}
mingw-qt5-qtsensors.spec:26: W: macro-in-comment %{qt_module}
mingw-qt5-qtsensors.spec:26: W: macro-in-comment %{snapshot_rev}
mingw-qt5-qtsensors.spec: W: invalid-url Source0: qt5-qtsensors-ceec1eda.tar.gz
0 packages and 1 specfiles checked; 0 errors, 5 warnings.

$ rpmlint mingw-qt5-qtsensors-5.0.0-0.5.git20130510.ceec1eda.fc20.src.rpm 
mingw-qt5-qtsensors.src: E: unknown-key GPG#9b393ae8
mingw-qt5-qtsensors.src:26: W: macro-in-comment %{qt_module}
mingw-qt5-qtsensors.src:26: W: macro-in-comment %{snapshot_rev}
mingw-qt5-qtsensors.src:26: W: macro-in-comment %{qt_module}
mingw-qt5-qtsensors.src:26: W: macro-in-comment %{snapshot_rev}
mingw-qt5-qtsensors.src: W: invalid-url Source0: qt5-qtsensors-ceec1eda.tar.gz
1 packages and 0 specfiles checked; 1 errors, 5 warnings.

$ rpmlint
results_mingw-qt5-qtsensors/5.0.0/0.5.git20130510.ceec1eda.fc18/mingw*.noarch.rpm
mingw32-qt5-qtsensors.noarch: W: no-documentation
mingw32-qt5-qtsensors-debuginfo.noarch: E: debuginfo-without-sources
mingw64-qt5-qtsensors.noarch: W: no-documentation
mingw64-qt5-qtsensors-debuginfo.noarch: E: debuginfo-without-sources
4 packages and 0 specfiles checked; 2 errors, 2 warnings.

$ rpm -q --requires mingw32-qt5-qtsensors
rpmlib(FileDigests) <= 4.6.0-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(CompressedFileNames) <= 3.0.4-1
mingw32-crt
mingw32-filesystem >= 83
mingw32(kernel32.dll)
mingw32(libgcc_s_sjlj-1.dll)
mingw32(libstdc++-6.dll)
mingw32(msvcrt.dll)
mingw32(qt5core.dll)
mingw32(qt5qml.dll)
mingw32(qt5sensors.dll)
rpmlib(PayloadIsXz) <= 5.2-1

$ rpm -q --requires mingw64-qt5-qtsensors
rpmlib(FileDigests) <= 4.6.0-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(CompressedFileNames) <= 3.0.4-1
mingw64-crt
mingw64-filesystem >= 83
mingw64(kernel32.dll)
mingw64(libstdc++-6.dll)
mingw64(msvcrt.dll)
mingw64(qt5core.dll)
mingw64(qt5qml.dll)
mingw64(qt5sensors.dll)
rpmlib(PayloadIsXz) <= 5.2-1

$ rpm -q --provides mingw32-qt5-qtsensors
mingw32-qt5-qtsensors = 5.0.0-0.5.git20130510.ceec1eda.fc18
mingw32(qt5sensors.dll)
mingw32(qtsensorgestures_plugin.dll)
mingw32(qtsensorgestures_shakeplugin.dll)
mingw32(qtsensors_dummy.dll)
mingw32(qtsensors_generic.dll)
mingw32(declarative_sensors.dll)

$ rpm -q --provides mingw64-qt5-qtsensors
mingw64-qt5-qtsensors = 5.0.0-0.5.git20130510.ceec1eda.fc18
mingw64(qt5sensors.dll)
mingw64(qtsensorgestures_plugin.dll)
mingw64(qtsensorgestures_shakeplugin.dll)
mingw64(qtsensors_dummy.dll)
mingw64(qtsensors_generic.dll)
mingw64(declarative_sensors.dll)


+ OK
! Needs to be looked into
/ Not applicable

[+] Compliant with generic Fedora Packaging Guidelines
[+] Source package name is prefixed with 'mingw-'
[+] Spec file starts with %{?mingw_package_header}
[+] BuildRequires: mingw32-filesystem >= 95 is in the .spec file
[+] BuildRequires: mingw64-filesystem >= 95 is in the .spec file
[+] Spec file contains %package sections for both mingw32 and mingw64 packages
[+] Binary mingw32 and mingw64 packages are noarch
[+] Spec file contains %{?mingw_debug_package} after the %description section
[+] Uses one of the macros %mingw_configure, %mingw_cmake, %mingw_cmake_kde4
    or %mingw_qmake_qt5 to configure the package
[+] Uses the macro %mingw_make to build the package
[+] Uses the macro %mingw_make to install the package
[+] If package contains translations, the %mingw_find_lang macro must be used
[+] No binary package named mingw-$pkgname is generated
[+] Libtool .la files are not bundled
[+] .def files are not bundled
[+] Man pages which duplicate native package are not bundled
[+] Info files which duplicate native package are not bundled
[+] Provides of the binary mingw32 and mingw64 packages are equal
[+] Requires of the binary mingw32 and mingw64 packages are equal

All of the discrepancies and warnings have been discussed before and are
acceptable.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=HoiKTrNX5U&a=cc_unsubscribe