Can someone review some spec files for me?

[David Nielsen]

2009/4/30 Stephen Shaw <sshaw at decriptor.com>

> These are the spec files that we are using to build rpms for openSUSE.
>  I was wondering if someone won't mind looking at them since I've
> never build packages for fedora.  There packages require mono 2.4 so
> I'm hoping to be able to provide packages for fedora 11.  Some of the
> specs don't have versions on them.  That's because these files are
> stored in our trunk and the versions get set when we branch and tag.
>
> Thanks!
>
> Stephen
>
> http://anonsvn.mono-project.com/viewvc/trunk/uia2atk/build/specs/
>

You will need to restructure the spec layout to fit better with the Fedora
way of doing things. Also you are not allowed to use %{_prefix} as that
would break our currently terrible Mono packaging guidelines which require
that we build Mono stuff as arch - please use %{_libdir} instead.

You need to keep a changelog.

I also believe that adding copyright notices to spec files in generally
frowned upon.

AutoReqProv:    on seems like SuSE magic and should perish

Release should be > 0

pkgconfig files go in a separate -devel package

I only briefly looked at one spec file but generally it looks like an
excellent start

The Banshee spec is a fairly well kept example to go by (just ignore the
commented buildrequires, that's maintainer preference and not the general
style).

http://cvs.fedoraproject.org/viewvc/rpms/banshee/F-11/banshee.spec?revision=1.75&view=markup

Good work Sr. Shaw.

- David
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.fedoraproject.org/pipermail/mono/attachments/20090430/934b9708/attachment.html