[Fedora-haskell-list] [Bug 537979] Review Request: ghc-hashed-storage - Hashed file storage support

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=537979

Christoph Wickert <cwickert at fedoraproject.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cwickert at fedoraproject.org

--- Comment #16 from Christoph Wickert <cwickert at fedoraproject.org> 2010-01-30 11:54:44 EST ---
I'm not familiar with haskell, but looking at the spec I wonder what's the use
of using globals for name, summary and description and depends?

Using globals only makes sense if
- the their contents is changing a lot
- if the conditionals are used in the spec several times.

Nether is the case and it makes the spec hard to read and rpmlint.

BTW: Was this package ever rpmlint'ed during review?

$ rpmlint ~/Desktop/ghc-hashed-storage-0.3.9-2.fc12.src.rpm 
ghc-hashed-storage.src: W: strange-permission hashed-storage-0.3.9.tar.gz 0600
ghc-hashed-storage.src: W: no-cleaning-of-buildroot %install
ghc-hashed-storage.src: W: no-buildroot-tag
1 packages and 0 specfiles checked; 0 errors, 3 warnings.

The missing "rm -rf $RPM_BUILD_ROOT" is not in the %cabal_install macro ether:
$ rpm --eval %cabal_install
/usr/bin/runghc Setup copy --destdir=${RPM_BUILD_ROOT} -v

$ rpmlint ghc-hashed-storage*0.3.9-2.fc13.i686.rpm
ghc-hashed-storage.i686: W: unstripped-binary-or-object
/usr/lib/ghc-6.12.1/hashed-storage-0.3.9/libHShashed-storage-0.3.9-ghc6.12.1.so
ghc-hashed-storage.i686: W: executable-stack
/usr/lib/ghc-6.12.1/hashed-storage-0.3.9/libHShashed-storage-0.3.9-ghc6.12.1.so
ghc-hashed-storage-devel.i686: W: no-documentation
ghc-hashed-storage-prof.i686: E: devel-dependency ghc-hashed-storage-devel
ghc-hashed-storage-prof.i686: W: no-documentation
ghc-hashed-storage-prof.i686: W: devel-file-in-non-devel-package
/usr/lib/ghc-6.12.1/hashed-storage-0.3.9/libHShashed-storage-0.3.9_p.a
4 packages and 0 specfiles checked; 1 errors, 5 warnings.

I was trying to build this in mock, but it fails:

F-12:
+ %cabal_configure --ghc -p
/var/tmp/rpm-tmp.sYV5fI: line 29: fg: no job control

F-13:
Configuring hashed-storage-0.4.5...
Setup: At least the following dependencies are missing:
binary -any, dataenc -any

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.