[Bug 1069062] Review Request: cabal-install - Command-line interface for Cabal and Hackage

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1069062



--- Comment #5 from Simone Caronni <negativo17 at gmail.com> ---
> [!]: Package does not own files or directories owned by other packages.
>     Note: Dirs in package are owned also by: /etc/bash_completion.d(git,
>     rpmdevtools, filesystem, pulseaudio, yum-utils, bash-completion, fedpkg,
>     udisks)
> [!]: Requires correct, justified where necessary.

The package should not own %{_sysconfdir}/bash_completion.d, as it is owned by
the package "filesystem". Also the directory %{_sysconfdir}/profile.d is owned
by the setup package.
Please change the %files section as follows:

%{_sysconfdir}/bash_completion.d/cabal
%{_sysconfdir}/profile.d/cabal-install.sh

Or:

%{_sysconfdir}/bash_completion.d/*
%{_sysconfdir}/profile.d/*

And add the following Requires at the top:

Requires:   filesystem
Requires:   setup

> [!]: Latest version is packaged.

According to http://hackage.haskell.org/package/cabal-install, the last version
is 1.18.0.3. Is there any reason for why it's not packaged?


> Rpmlint
> -------
> cabal-install.x86_64: W: non-conffile-in-etc /etc/profile.d/cabal-install.sh
> cabal-install.x86_64: W: non-conffile-in-etc /etc/bash_completion.d/cabal

Please mark the files as %config or better %config(noreplace). If they are not
edited by the user; they will be updated anyway if the package gets updated..

%config(noreplace) %{_sysconfdir}/bash_completion.d/cabal
%config(noreplace) %{_sysconfdir}/profile.d/cabal-install.sh

Apart from these small issues, the package is good to go! Please confirm this
is a re-review for unorphaning the package in devel.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=tmLuZbUhY7&a=cc_unsubscribe