<html>
<head>
<base href="https://bugzilla.redhat.com/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_ASSIGNED "
title="ASSIGNED --- - Review Request: fcitx-cloudpinyin - Cloudpinyin module for fcitx"
href="https://bugzilla.redhat.com/show_bug.cgi?id=801058#c3">Comment # 3</a>
from <span class="vcard "><a class="email" href="mailto:liangsuilong@gmail.com" title="Liang Suilong <liangsuilong@gmail.com>"> <span class="fn">Liang Suilong</span></a>
</span></b>
<pre>SPEC: <a href="http://liangsuilong.fedorapeople.org/fcitx/fcitx-cloudpinyin.spec">http://liangsuilong.fedorapeople.org/fcitx/fcitx-cloudpinyin.spec</a>
SRPM:
<a href="http://liangsuilong.fedorapeople.org/fcitx/fcitx-cloudpinyin-0.2.1-1.fc16.src.rpm">http://liangsuilong.fedorapeople.org/fcitx/fcitx-cloudpinyin-0.2.1-1.fc16.src.rpm</a>
Koji: <a href="http://koji.fedoraproject.org/koji/taskinfo?taskID=4091875">http://koji.fedoraproject.org/koji/taskinfo?taskID=4091875</a>
(In reply to <a href="show_bug.cgi?id=801058#c1">comment #1</a>)
<span class="quote">> Review:-
> + koji scratch build for f17 ->
> <a href="http://koji.fedoraproject.org/koji/taskinfo?taskID=4024897">http://koji.fedoraproject.org/koji/taskinfo?taskID=4024897</a>
>
> + rpmlint on rpms gave
> fcitx-cloudpinyin.src: W: spelling-error %description -l en_US Cloulpinyin
> -> Cloudiness
> fcitx-cloudpinyin.src:5: W: mixed-use-of-spaces-and-tabs (spaces: line 1,
> tab: line 5)
> fcitx-cloudpinyin.src: W: invalid-url Source0:
> <a href="http://fcitx.googlecode.com/files/fcitx-cloudpinyin-0.2.0.tar.bz2">http://fcitx.googlecode.com/files/fcitx-cloudpinyin-0.2.0.tar.bz2</a> HTTP Error
> 404: Not Found
> fcitx-cloudpinyin.x86_64: W: spelling-error %description -l en_US
> Cloulpinyin -> Cloudiness
> 2 packages and 0 specfiles checked; 0 errors, 4 warnings.
>
> + Source verified with upstream as (sha1sum)
> d9337b344fbefde61689e0a5aa9f54530a6b6c71 fcitx-cloudpinyin-0.2.0.tar.bz2
> d9337b344fbefde61689e0a5aa9f54530a6b6c71
> ../SOURCES/fcitx-cloudpinyin-0.2.0.tar.bz2
>
> + Package : fcitx-cloudpinyin-0.2.0-1.fc17.x86_64
> Provides: fcitx-cloudpinyin.so()(64bit)
> Requires: libc.so.6()(64bit) libc.so.6(GLIBC_2.14)(64bit)
> libc.so.6(GLIBC_2.2.5)(64bit) libcurl.so.4()(64bit) rtld(GNU_HASH)
>
> Suggestions:-
> 1) Fix the rpmlint messages.
> a) mixed-use-of-spaces-and-tabs message can be fixed using command
> sed -i 's|\t| |g' fcitx-cloudpinyin.spec
> b) description lines should be of 80 characters.</span >
Fixed.
<span class="quote">>
> 2) If package is only for Fedora then no need to add
> a) %clean section (see
> <a href="http://fedoraproject.org/wiki/Packaging:Guidelines#.25clean">http://fedoraproject.org/wiki/Packaging:Guidelines#.25clean</a>)
> b) removal of buildroot in %install (remove line rm -rf $RPM_BUILD_ROOT)
> c) remove line %defattr(-,root,root,-)
> </span >
The packages will support EL-6
<span class="quote">> 3) please don't use commands in macro that is change %{__mkdir} to "mkdir"
> </span >
Fixed
<span class="quote">> 4) package should add Requires: fcitx, fcitx-data
> </span >
Fixed, add fcitx only
<span class="quote">> 5) Use following commands in %build
> %cmake ..
> make VERBOSE=1 %{?_smp_mflags}
> </span >
Fixed
<span class="quote">> 6) %install should preserve timestamp using
> make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p"</span >
>
Fixed
<span class="quote">> 7) Add COPYING to %doc</span >
Fixed</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>