Michel,<div><br></div><div>Excellent!</div><div><br></div><div>I've done some additional work on the package, including building the vimclojure nailgun server and installing the jar (as the guidelines require using mvn-rpmbuild). In the source, the server uses lein to build, but it's a trivial Maven POM to write because all it's doing is compiling Java with no external dependencies other than Clojure. Therefore, I just added the POM to the spec and voila, it builds :)</div>
<div><br></div><div>Since I'm now installing the vimclojure nailgun server, I think it's reasonable to include nailgun as a dependency. Here's the experience the user can expect:</div><div><br></div><div>(in terminal #1)</div>
<div>sudo yum install vimclojure</div><div>java -jar /usr/share/java/vimclojure/server.jar</div><div><br></div><div>(in terminal #2)</div><div>vim test.clj</div><div>type: let g:vimclojure#WantNailgun = 1</div><div>type: (println "Hello, World")</div>
<div>type: \et</div><div><br></div><div>And voila, they see "Hello, World" printed in a split buffer.</div><div><br></div><div>That's a pretty stellar experience compared to what it takes to get VimClojure setup manually.</div>
<div><br></div><div>I opted to name the package "vimclojure" since it's providing both the server jar (in JPP-compliant fashion) and the vimfiles. In review, we could consider sub-packages, but for now it really makes a lot of sense to me to keep it together.</div>
<div><br></div><div>I'd say the package is ready for review!</div><div><br></div><div>Please note that I changed the name of the repository. It's now here:</div><div><br></div><div><a href="https://github.com/mojavelinux/fedorapkg-vimclojure">https://github.com/mojavelinux/fedorapkg-vimclojure</a></div>
<div><br></div><div>-Dan</div><div><br></div><div>p.s. Btw, the vimclojure server jar will come in handy for leiningin as it will provide the jar file needed for lein-tarsier (if you want to only use system jar files).</div>
<div><br><div class="gmail_quote">On Sun, Aug 26, 2012 at 12:45 AM, Michel Alexandre Salim <span dir="ltr"><<a href="mailto:salimma@fedoraproject.org" target="_blank">salimma@fedoraproject.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">-----BEGIN PGP SIGNED MESSAGE-----<br>
Hash: SHA1<br>
<br>
Hi Dan,<br>
<br>
I'd be thrilled to sponsor you if you'd like to be a developer.<br>
Failing which, one of Kushal or myself can officially propose the<br>
package, with your help in case we run into problems.<br>
<br>
Fedora packaging guidelines currently does not allow for optional<br>
dependencies (recommendations/suggestions) -- athough I believe<br>
openSUSE and Mandriva use them. So I'd say it depends on whether it<br>
adds substantial functionality or not; if not, maybe a mention in a<br>
README.Fedora file suggesting the other package be installed is<br>
sufficient.<br>
<br>
Let me know what you think.<br>
<br>
Best,<br>
<div class="im"><br>
On 08/26/2012 02:20 AM, Dan Allen wrote:<br>
> I've prepared a spec file for this package. I've tested it and it<br>
> works to my satisfaction.<br>
><br>
> <a href="https://github.com/mojavelinux/fedorapkg-vim-vimclojure" target="_blank">https://github.com/mojavelinux/fedorapkg-vim-vimclojure</a><br>
><br>
> Feel free to move the files to wherever they need to go.<br>
><br>
> I have two open questions:<br>
><br>
> 1. Should the package be named vim-vimclojure (as it is) or<br>
> vim-clojure? 2. Should the package require nailgun, or should the<br>
> user have to install that package separately? (Note that vimclojure<br>
> will function without nailgun)<br>
><br>
> (Btw, is there a way to mark a package dependency as optional or<br>
> recommended?)<br>
><br>
> -Dan<br>
><br>
> On Sat, Aug 25, 2012 at 12:41 PM, Dan Allen <<a href="mailto:dan.j.allen@gmail.com">dan.j.allen@gmail.com</a><br>
</div><div><div class="h5">> <mailto:<a href="mailto:dan.j.allen@gmail.com">dan.j.allen@gmail.com</a>>> wrote:<br>
><br>
> Kushal and Michel,<br>
><br>
> I noticed that you're leading up the effort to package Leiningen<br>
> for Fedora 18, for which I'm thrilled. Would you consider<br>
> sponsering a package for vimclojure [1] as well? Nailgun is already<br>
> available in Fedora [2], so it's just a matter of package the vim<br>
> scripts. I imagine the package would look very similar to<br>
> vim-nerdtree [3], so we could build on that.<br>
><br>
> I'm not a Fedora packager, but I would be willing to help put the<br>
> package together. WDYT? I think this would be big for Clojure<br>
> developers (obviously those that use vim, but perhaps developers<br>
> who haven't experienced good repl editor integration).<br>
><br>
> -Dan<br>
><br>
> [1] <a href="http://www.vim.org/scripts/script.php?script_id=2501" target="_blank">http://www.vim.org/scripts/script.php?script_id=2501</a> [2]<br>
> <a href="https://admin.fedoraproject.org/pkgdb/acls/name/nailgun" target="_blank">https://admin.fedoraproject.org/pkgdb/acls/name/nailgun</a> [3]<br>
> <a href="http://pkgs.fedoraproject.org/cgit/vim-nerdtree.git/tree/vim-nerdtree.spec" target="_blank">http://pkgs.fedoraproject.org/cgit/vim-nerdtree.git/tree/vim-nerdtree.spec</a><br>
><br>
> -- Dan Allen Principal Software Engineer, Red Hat | Author of Seam<br>
> in Action Registered Linux User #231597<br>
><br>
> <a href="http://google.com/profiles/dan.j.allen" target="_blank">http://google.com/profiles/dan.j.allen</a> <a href="http://mojavelinux.com" target="_blank">http://mojavelinux.com</a><br>
> <a href="http://mojavelinux.com/seaminaction" target="_blank">http://mojavelinux.com/seaminaction</a><br>
><br>
><br>
><br>
><br>
> -- Dan Allen Principal Software Engineer, Red Hat | Author of Seam<br>
> in Action Registered Linux User #231597<br>
><br>
> <a href="http://google.com/profiles/dan.j.allen" target="_blank">http://google.com/profiles/dan.j.allen</a> <a href="http://mojavelinux.com" target="_blank">http://mojavelinux.com</a><br>
> <a href="http://mojavelinux.com/seaminaction" target="_blank">http://mojavelinux.com/seaminaction</a><br>
><br>
<br>
<br>
</div></div>- --<br>
Michel Alexandre Salim<br>
Fedora Project Contributor: <a href="http://fedoraproject.org/" target="_blank">http://fedoraproject.org/</a><br>
<br>
Email: <a href="mailto:salimma@fedoraproject.org">salimma@fedoraproject.org</a> | GPG key ID: A36A937A<br>
Jabber: <a href="mailto:hircus@jabber.ccc.de">hircus@jabber.ccc.de</a> | IRC: <a href="mailto:hircus@irc.freenode.net">hircus@irc.freenode.net</a><br>
<br>
() ascii ribbon campaign - against html e-mail<br>
/\ <a href="http://www.asciiribbon.org" target="_blank">www.asciiribbon.org</a> - against proprietary attachments<br>
-----BEGIN PGP SIGNATURE-----<br>
Version: GnuPG v1.4.12 (GNU/Linux)<br>
Comment: Using GnuPG with Mozilla - <a href="http://www.enigmail.net/" target="_blank">http://www.enigmail.net/</a><br>
<br>
iQEcBAEBAgAGBQJQOanRAAoJEEr1VKujapN6YgEH/j29xUwwi7xJqrTuKxBBPpyT<br>
imt0CeuW7ZIYLVT9VcheaEisvtY4o1EdIsiWyWheHb0AojmPWNhxzrER316CaA+F<br>
BYwvYEiPnftftowmKAcBSAI8hqUUImWXcv/hzxcl/5L/0yCxKBi6dPfXio9jUiJb<br>
/xYBE0bSHAd866pkHV7f8Z0FYDYRsvtLD6dP93z9xCLs/SsPapHS8wK2I6rjJxuZ<br>
yI0r585vbBcYJ+6oBo0TFJWKQDXVYYAnbRleGSCEa4R8U3LUjyOjPAXOWHQK+r2q<br>
x/MC+P2CrfDhffhmXfGD3eDc1FZ5hvk/Xmt0SEHCTEgB0Mp7ku5HCEc1HmaZIQ0=<br>
=CULo<br>
-----END PGP SIGNATURE-----<br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div>Dan Allen</div>Principal Software Engineer, Red Hat | Author of Seam in Action<br>Registered Linux User #231597<br><br><div><a href="http://google.com/profiles/dan.j.allen" target="_blank">http://google.com/profiles/dan.j.allen</a><br>
<a href="http://mojavelinux.com" target="_blank">http://mojavelinux.com</a><br><a href="http://mojavelinux.com/seaminaction" target="_blank">http://mojavelinux.com/seaminaction</a><br></div><br>
</div>