<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On 4 June 2015 at 09:19, Noa Resare <span dir="ltr"><<a href="mailto:noa@spotify.com" target="_blank">noa@spotify.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div>First off I would like to say that I'm very impressed by the effort you have put into java packaging over the last few years. Getting a usable environment for offline maven execution is no small feat.</div><div><br></div><div>One thing I noted, however, was that the unit tests for the guava library was not run on package build. Which seems like a reasonable compromise but not ideal. I decided to look into what would be needed dependency wise for that to happen, and I came up with the following:</div><div><br></div><div>* updates-testing needs to be activated for the auto-value dependency.</div><div><br></div><div>* packages truth, allocation-instrumenter and caliper needs to be introduced. I have created those packages and built them with guidance from the <a href="https://fedorahosted.org/released/javapackages/doc/" target="_blank">Java Packaging HOWTO</a>, the packages (SRPMS and mock built noarch.rpms) are available from <a href="https://resare.com/noa-fedora-playground/repo/22" target="_blank">https://resare.com/noa-fedora-playground/repo/22</a> but please beware of newbie packaging mistakes :)</div><div><br></div><div>* With the dependencies handled I updated guava.spec to re-enable guava-testlib and guava-tests. One test was consistently failing due to new java8 behaviour, and I back ported a fix from guava master. The changes needed can be viewed in my fork of git://<a href="http://pkgs.fedoraproject.org/guava.git" target="_blank">pkgs.fedoraproject.org/guava.git</a> at <a href="https://github.com/nresare/fedora-guava" target="_blank">https://github.com/nresare/fedora-guava</a> in the testlib-tests branch. The actual commit can be viewed here: <a href="https://github.com/nresare/fedora-guava/commit/c1a8a831b1ef0ec91509fea8066258629c215707" target="_blank">https://github.com/nresare/fedora-guava/commit/c1a8a831b1ef0ec91509fea8066258629c215707</a></div><div><br></div><div>I would love for my work to be of use in the fedora project and I'm willing to spend some time to land my contributions at this time. I will now read up on what I need to to contribute more formally.</div><span class=""><font color="#888888"><div><br></div><div>/noa</div><div><br></div>-- <br><div><div dir="ltr">Spotify Free Software ombudsman. I/O Tribe.</div></div>
</font></span></div>
<br>--<br>
java-devel mailing list<br>
<a href="mailto:java-devel@lists.fedoraproject.org">java-devel@lists.fedoraproject.org</a><br>
<a href="https://admin.fedoraproject.org/mailman/listinfo/java-devel" target="_blank">https://admin.fedoraproject.org/mailman/listinfo/java-devel</a><br></blockquote></div><br></div><div class="gmail_extra"><br>This is great to hear -- it sounds like useful work you have done and I look forward to seeing your new packages appear in Fedora :-)<br><br></div><div class="gmail_extra">I assume you have seen this document already: <a href="https://fedoraproject.org/wiki/Join_the_package_collection_maintainers?rd=PackageMaintainers/Join">https://fedoraproject.org/wiki/Join_the_package_collection_maintainers?rd=PackageMaintainers/Join</a><br></div><div class="gmail_extra"><br clear="all"></div><div class="gmail_extra"><br>-- <br><div class="gmail_signature">Mat Booth<br><a href="http://fedoraproject.org/get-fedora" target="_blank">http://fedoraproject.org/get-fedora</a></div>
</div></div>