[PATCH 1/3] [RFC] Print a device-tree message at KERN_WARNING level

[Josh Boyer]

On Thu, Feb 3, 2011 at 5:07 PM, Paul Bolle <pebolle at tiscali.nl> wrote:
> For the message
>    /proc/device-tree: can't find root
>
> KERN_WARNING seems to be more appropriate than KERN_ERR. (Main benefit
> of the KERN_WARNING level is that Fedora's plymouth bootsplash should
> now hide it.)
>
> Signed-off-by: Paul Bolle <pebolle at tiscali.nl>
> ---
>  fs/proc/proc_devtree.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/fs/proc/proc_devtree.c b/fs/proc/proc_devtree.c
> index d9396a4..71dd779 100644
> --- a/fs/proc/proc_devtree.c
> +++ b/fs/proc/proc_devtree.c
> @@ -233,7 +233,7 @@ void __init proc_device_tree_init(void)
>                return;
>        root = of_find_node_by_path("/");
>        if (root == NULL) {
> -               printk(KERN_ERR "/proc/device-tree: can't find root\n");
> +               printk(KERN_WARNING "/proc/device-tree: can't find root\n");
>                return;

You should only see this if you are running on a machine that has an
OpenFirmware style device tree and CONFIG_OF and
CONFIG_PROC_DEVICETREE are set.  Given the other patches in your set,
I don't think you are running on a PowerPC machine.  Unless you have
an OLPC, then your config is just adding bloat.  (And if you do have
an OLPC, that would be odd anyway.)

On machines where this is supposed to be used, it likely is an error.

That being said, you can send this patch to the devicetree-discuss
mailing list on list.ozlabs.org for further feedback.

josh