[kernel] Disable debugging options.

[Josh Boyer]

On Mon, Jun 18, 2012 at 10:05:38PM +0200, Thorsten Leemhuis wrote:
> On 18.06.2012 15:09, Josh Boyer wrote:
> > commit 3b37beedf48825354c42e25f7001677320958d38
> > Author: Josh Boyer <jwboyer at redhat.com>
> > Date:   Mon Jun 18 09:09:58 2012 -0400
> > 
> >     Disable debugging options.
> > 
> >  config-generic     |    8 ++--
> >  config-nodebug     |  112 ++++++++++++++++++++++++++--------------------------
> >  config-x86-generic |    2 +-
> >  kernel.spec        |    9 +++-
> >  4 files changed, 67 insertions(+), 64 deletions(-)
> > ---
> > diff --git a/config-generic b/config-generic
> > index 6b1c651..08c28ba 100644
> > --- a/config-generic
> > +++ b/config-generic
> > @@ -1446,13 +1446,13 @@ CONFIG_B43_SDIO=y
> >  CONFIG_B43_BCMA=y
> >  # CONFIG_B43_BCMA_EXTRA is not set
> >  CONFIG_B43_BCMA_PIO=y
> > -CONFIG_B43_DEBUG=y
> > +# CONFIG_B43_DEBUG is not set
> > [...]
> 

I hesitated to reply because I honestly don't know _why_ it's done this
way.  You ask a good question though, and I didn't want you to think we
were ignoring it so I'll reply with what I do know (which isn't much).

> Just out of curiosity: Why is enabling and disabling the debug options
> done via "make {no,}debug" in the git checkout and not by an conditional
> within the spec file? That afaics makes it harder to switch the debug
> options off if you only have the SRPM at hand.

It's actually done with 'make debug' and 'make release'.  Those run a
bunch of perl invocations to toggle the options on or off in various
config- files.

> Or am I missing something obvious here?

I don't think you're missing anything obvious.  The config- file munging
has been around longer than Fedora has so at this point it's "just how
it's done".  If someone wanted to come up with a way to accomplish the
same thing by toggling a value in the spec file, that might actually be
good.

josh