[PATCH PULL F16 F17] task_work_add: generic process-context callbacks

Oleg Nesterov oleg at redhat.com
Tue Jun 26 16:28:52 UTC 2012


On 06/25, Anton Arapov wrote:
>
> --- a/include/linux/tracehook.h
> +++ b/include/linux/tracehook.h
> @@ -49,6 +49,7 @@
>  #include <linux/sched.h>
>  #include <linux/ptrace.h>
>  #include <linux/security.h>
> +#include <linux/task_work.h>
>  struct linux_binprm;
>
>  /*
> @@ -165,8 +166,10 @@ static inline void tracehook_signal_handler(int sig, siginfo_t *info,
>   */
>  static inline void set_notify_resume(struct task_struct *task)
>  {
> +#ifdef TIF_NOTIFY_RESUME
>  	if (!test_and_set_tsk_thread_flag(task, TIF_NOTIFY_RESUME))
>  		kick_process(task);
> +#endif
>  }

FYI, this change is not exactly correct...

The patch should also remove another "ifdef TIF_NOTIFY_RESUME" above,
see the original patch: http://marc.info/?l=linux-kernel&m=133487746527839

This part was lost because the patch was routed via Al Viro's tree,
and that ifdef was already killed by 1227dd77

However, I guess we do not care, fedora kernel doesn't run on
!TIF_NOTIFY_RESUME machines.

So I think the patch is fine for F16/F17

Oleg.



More information about the kernel mailing list