[PATCH] sunrpc: set CONFIG_SUNRPC_DEBUG=y in config.debug

[Jeff Layton]

On Fri, 11 May 2012 09:27:26 -0400
Josh Boyer <jwboyer at redhat.com> wrote:

> On Fri, May 11, 2012 at 08:40:32AM -0400, Jeff Layton wrote:
> > This is quite handy for debugging but was recently made optional in
> > mainline kernels since it shrinks the size of the rpc/nfs modules
> > substantially if you turn it off.
> > 
> > This patch turns it on in debug kernels. Should we also consider
> > reenabling this in non-debug kernels?
> > 
> > Signed-off-by: Jeff Layton <jlayton at redhat.com>
> 
> From a Fedora perspective, we were already shipping all kernels with the
> equivalent of this being enabled since we enable CONFIG_SYSCTL, right?
> 

Right. The ability to compile out these debug messages is a recent
addition, and it's off by default. Turning it back on would be
returning Fedora back to the way it was.

> If that's the case and it is going to make debugging NFS issues easier,
> then I don't see a reason to not always enable it.  If a ton more
> debugging things get added and make it really slow, we can always
> revisit.
> 
> Does that sound reasonable to everyone?
> 
> josh

That's fine with me. Did you want me to respin the patch, or can you
fix it up?

Thanks,
-- 
Jeff Layton <jlayton at redhat.com>