[PATCH] Drop the old Adaptec AIC7xxx driver
Paul Bolle
pebolle at tiscali.nl
Sat Feb 2 08:27:46 UTC 2013
On Thu, 2012-11-01 at 10:56 +0100, Paul Bolle wrote:
> Ever since v2.4.3 this driver is advertised as not being under active
> development. It's main advantage to most users will be the warnings it
> generates at build time:
> drivers/scsi/aic7xxx_old.c: In function ‘aic7xxx_register’:
> drivers/scsi/aic7xxx_old.c:7901:5: warning: case value ‘257’ not in enumerated type ‘ahc_chip’ [-Wswitch]
> drivers/scsi/aic7xxx_old.c:7898:5: warning: case value ‘513’ not in enumerated type ‘ahc_chip’ [-Wswitch]
> drivers/scsi/aic7xxx_old.c: In function ‘aic7xxx_load_seeprom’:
> drivers/scsi/aic7xxx_old.c:8517:5: warning: case value ‘257’ not in enumerated type ‘ahc_chip’ [-Wswitch]
> drivers/scsi/aic7xxx_old.c:8510:5: warning: case value ‘513’ not in enumerated type ‘ahc_chip’ [-Wswitch]
>
> Let's drop this old driver.
>
> Signed-off-by: Paul Bolle <pebolle at tiscali.nl>
CONFIG_SCSI_AIC7XXX_OLD is still in current master of kernel.git. Did
anyone have a chance to look at this patch (which is, by now, actually
tested)?
Paul Bolle
> 0) I'm trying to get my kernel builds (which use the Fedora kernel
> config) warning free. Upstream declined the brilliant fix to silence
> these warnings (see https://lkml.org/lkml/2012/9/21/104 ).
>
> 1) Plan B is to simply drop this old driver in the Fedora kernel
> altogether. That should silence these warnings too, shouldn't it? But is
> dropping this old driver acceptable?
>
> 2) This patch is entirely untested.
>
> config-generic | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/config-generic b/config-generic
> index 4a8015f..5cc8f8d 100644
> --- a/config-generic
> +++ b/config-generic
> @@ -341,7 +341,6 @@ CONFIG_SCSI_3W_9XXX=m
> CONFIG_SCSI_ACARD=m
> CONFIG_SCSI_AACRAID=m
> CONFIG_SCSI_AIC7XXX=m
> -CONFIG_SCSI_AIC7XXX_OLD=m
> CONFIG_AIC7XXX_CMDS_PER_DEVICE=4
> CONFIG_AIC7XXX_RESET_DELAY_MS=15000
> # CONFIG_AIC7XXX_BUILD_FIRMWARE is not set
More information about the kernel
mailing list