[PATCH] kernel.spec: let flavors/variants end with "-$flavor" in the uname

Harald Hoyer harald at redhat.com
Wed Jun 12 13:47:00 UTC 2013


On 06/11/2013 08:44 PM, Thorsten Leemhuis wrote:
> Hi!
> 
> Me again with another comment:
> 
> On 11.06.2013 16:44, harald at redhat.com wrote:
>> From: Harald Hoyer <harald at redhat.com>
>> [...]
>> -Provides: kernel-%{_target_cpu} = %{rpmversion}-%{pkg_release}%{?1:.%{1}}\
>> +Provides: kernel-%{_target_cpu} = %{rpmversion}-%{pkg_release}%{?1:-%{1}}\
> 
> Is it really wise to use a "-" here? You can not have a "-" in either
> %{version} or %{release}, to afaics make sure everything can parse a rpm
> nvr from right to left: %{version} is between second rightmost dash and
> the rightmost dash; %{release} follows the rightmost dash.
> 
> I'm sure you tested it, so I assume rpm doesn't enforce this rule to
> virtual provides. But something tells me this might create more problems
> then is solves. Did anyone ask the rpm and yum guys if this is a good idea?
> 
> Cu
> knurd
> 

Talked to the rpm guys, and yes, it's a problem.

So, any idea for a good separation char here?


More information about the kernel mailing list