[Fedora-livecd-list] Destructive behavior in --skipcopy option of livecd-iso-to-disk

[Frederick Grose]

The --skipcopy option in livecd-iso-to-disk was implemented to aid testing
and boot configuration file recovery (see
http://article.gmane.org/gmane.linux.redhat.fedora.livecd/2682).

I've found that it will overwrite both an existing persistent overlay and
home.img, if they exist.  This is unintentional destructive behavior.

While it may seem that one wouldn't ask for a new overlay or home folder
AND skipcopy--during the testing of scripts, this is a reasonable scenario.

I've filed a bug, https://bugzilla.redhat.com/show_bug.cgi?id=582051,
containing the attached skipcopy.patch.

Please review and advise me on how to proceed.

This is a piece of a project to enhance the livecd-iso-to-disk script for
the Sugar on a Stick customization kit project, but it has more general
benefits.

Again, please see https://bugzilla.redhat.com/show_bug.cgi?id=448030 and
advise.

I'm planning now to submit smaller change patches to make review easier.

          --Fred
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.fedoraproject.org/pipermail/livecd/attachments/20100414/8f434a28/attachment.html 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: skipcopy.patch
Type: text/x-patch
Size: 1500 bytes
Desc: not available
Url : http://lists.fedoraproject.org/pipermail/livecd/attachments/20100414/8f434a28/attachment.bin